pontem-network / harvest Goto Github PK

In unstake function we have few invokes of functions where arithmetic error can occur:

• fun update_accum_reward:

let total_reward = to_u128(pool.reward_per_sec) * to_u128(seconds_passed) * SIX_DECIMALS;
pool.accum_reward = pool.accum_reward + total_reward / to_u128(total_stake);

• fun update_user_earnings:

let earned = (accum_reward * (to_u128(user_stake.amount)) / SIX_DECIMALS) - user_stake.unobtainable_reward;
user_stake.earned_reward = user_stake.earned_reward + to_u64(earned);
user_stake.unobtainable_reward = user_stake.unobtainable_reward + earned;

• fun unstake:

user_stake.unobtainable_reward = (pool.accum_reward * to_u128(user_stake.amount)) / SIX_DECIMALS;

It is necessary to check the correctness of the calculations with boundary values. These calculations are also associated with issue #13.

For now we use six decimals in reward calculations:
const SIX_DECIMALS: u128 = 1000000;

Like in this case, user_stake.amount is stake coin amount with six decimals and result earned - amount for reward coin with six decimals:
let earned = (pool.accum_reward * (to_u128(user_stake.amount)) / SIX_DECIMALS) - user_stake.unobtainable_reward;

We need to come up with restrictions on decimals, adapt the calculations to their different values.

I need to update AptosFramework and related, include Liquidswap, to mainnet contains branches.