poma123 / pickupspawners Goto Github PK

Hi !

I'm currently running an 1.14.2 survival server, I have add a pickaxe with the command "/pspawner additem" this pickaxe has only 1 use left (a golden pickaxe with 31/32 damage) but it appaers that the damage of the pickaxe doesn't have any effect. If the pickaxe has 32/32 durability spawners are minable

[19:40:46 ERROR]: Could not pass event BlockBreakEvent to PickupSpawners v2.9.5
java.lang.NullPointerException: null
at me.poma123.spawners.Listener.isItemStacksGood(Listener.java:379) ~[?:?]
at me.poma123.spawners.Listener.onSpawnerBreak(Listener.java:498) ~[?:?]
at com.destroystokyo.paper.event.executor.asm.generated.GeneratedEventExecutor307.execute(Unknown Source) ~[?:?]
at org.bukkit.plugin.EventExecutor.lambda$create$1(EventExecutor.java:69) ~[patched_1.14.2.jar:git-Paper-65]
at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:80) ~[patched_1.14.2.jar:git-Paper-65]
at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:70) ~[patched_1.14.2.jar:git-Paper-65]
at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:536) ~[patched_1.14.2.jar:git-Paper-65]
at net.minecraft.server.v1_14_R1.PlayerInteractManager.breakBlock(PlayerInteractManager.java:291) ~[patched_1.14.2.jar:git-Paper-65]
at net.minecraft.server.v1_14_R1.PlayerInteractManager.a(PlayerInteractManager.java:84) ~[patched_1.14.2.jar:git-Paper-65]
at net.minecraft.server.v1_14_R1.EntityPlayer.tick(EntityPlayer.java:355) ~[patched_1.14.2.jar:git-Paper-65]
at net.minecraft.server.v1_14_R1.WorldServer.entityJoinedWorld(WorldServer.java:579) ~[patched_1.14.2.jar:git-Paper-65]
at net.minecraft.server.v1_14_R1.World.a(World.java:895) ~[patched_1.14.2.jar:git-Paper-65]
at net.minecraft.server.v1_14_R1.WorldServer.doTick(WorldServer.java:354) ~[patched_1.14.2.jar:git-Paper-65]
at net.minecraft.server.v1_14_R1.MinecraftServer.b(MinecraftServer.java:1177) ~[patched_1.14.2.jar:git-Paper-65]
at net.minecraft.server.v1_14_R1.DedicatedServer.b(DedicatedServer.java:418) ~[patched_1.14.2.jar:git-Paper-65]
at net.minecraft.server.v1_14_R1.MinecraftServer.a(MinecraftServer.java:1060) ~[patched_1.14.2.jar:git-Paper-65]
at net.minecraft.server.v1_14_R1.MinecraftServer.run(MinecraftServer.java:904) ~[patched_1.14.2.jar:git-Paper-65]
at java.lang.Thread.run(Thread.java:748) [?:1.8.0_212]

Describe the bug
Can we allow default player (without permission and tools) to break spawner like vanilla?It means that the spawner break and did not drop. When they have the correct permission + correct tool, then the spawner will break and drop.

How to reproduce
Steps to reproduce the behavior:
-Without permission, player cannot break the spawner.

Expected behavior
Without permission + correct tools, player can break the spawner but did not drop. With permission+ correct tools, player can break the spawner and the spawner drop.

Screenshots
N/a

About your server (please complete the following information):

• Server version: Spigot 1.13.2
• Plugin version: 2.9.7
• Plugins list : shopgui+, essentials

Additional context
Add any other context about the problem here.

Describe the bug
The tools no longer break the spawners when they lose durability.

How to reproduce
Steps to reproduce the behavior:

1. Set the tool for breaking spawners to anything that loses durability
2. Mine a spawner just to test it works
3. Get the tool to lose durability
4. It doesn't break the spawner

About your server (please complete the following information):

• Server version: [1.16.4]
• Plugin version [latest]

its a simple thing ive seen, and would love to just have it built into the code vs using a separate plug just to prevent spawner change via spawn eggs

For some reason every time I right click a block the plugin says "you do not have permission to do this". Giving permission pickupspawners.* fixes this issue, but I can't do that in public.
Right clicking still works normally other than the message in chat, console shows no errors. 1.13.2

I'm running on 1.14.4 and passive mobs like rabbits or pigs don't spawn in the desert (even though desert rabbits can spawn) can you add something into the config files to disable this.
Slimes only spawn in swamps as well.

Thanks!

[00:21:17 ERROR]: Could not pass event BlockBreakEvent to PickupSpawners v2.9.5
java.lang.NullPointerException: null
at me.poma123.spawners.Listener.isItemStacksGood(Listener.java:379) ~[?:?]
at me.poma123.spawners.Listener.onSpawnerBreak(Listener.java:498) ~[?:?]
at com.destroystokyo.paper.event.executor.asm.generated.GeneratedEventExecutor317.execute(Unknown Source) ~[?:?]
at org.bukkit.plugin.EventExecutor.lambda$create$1(EventExecutor.java:69) ~[patched_1.14.4.jar:git-Paper-166]
at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:80) ~[patched_1.14.4.jar:git-Paper-166]
at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:70) ~[patched_1.14.4.jar:git-Paper-166]
at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:545) ~[patched_1.14.4.jar:git-Paper-166]
at net.minecraft.server.v1_14_R1.PlayerInteractManager.breakBlock(PlayerInteractManager.java:303) ~[patched_1.14.4.jar:git-Paper-166]
at net.minecraft.server.v1_14_R1.PlayerInteractManager.a(PlayerInteractManager.java:262) ~[patched_1.14.4.jar:git-Paper-166]
at net.minecraft.server.v1_14_R1.PlayerInteractManager.a(PlayerInteractManager.java:236) ~[patched_1.14.4.jar:git-Paper-166]
at net.minecraft.server.v1_14_R1.PlayerConnection.a(PlayerConnection.java:1307) ~[patched_1.14.4.jar:git-Paper-166]
at net.minecraft.server.v1_14_R1.PacketPlayInBlockDig.a(SourceFile:40) ~[patched_1.14.4.jar:git-Paper-166]
at net.minecraft.server.v1_14_R1.PacketPlayInBlockDig.a(SourceFile:10) ~[patched_1.14.4.jar:git-Paper-166]
at net.minecraft.server.v1_14_R1.PlayerConnectionUtils.lambda$ensureMainThread$0(PlayerConnectionUtils.java:23) ~[patched_1.14.4.jar:git-Paper-166]
at net.minecraft.server.v1_14_R1.TickTask.run(SourceFile:18) ~[patched_1.14.4.jar:git-Paper-166]
at net.minecraft.server.v1_14_R1.IAsyncTaskHandler.executeTask(IAsyncTaskHandler.java:136) ~[patched_1.14.4.jar:git-Paper-166]
at net.minecraft.server.v1_14_R1.IAsyncTaskHandlerReentrant.executeTask(SourceFile:23) ~[patched_1.14.4.jar:git-Paper-166]
at net.minecraft.server.v1_14_R1.IAsyncTaskHandler.executeNext(IAsyncTaskHandler.java:109) ~[patched_1.14.4.jar:git-Paper-166]
at net.minecraft.server.v1_14_R1.MinecraftServer.aX(MinecraftServer.java:1012) ~[patched_1.14.4.jar:git-Paper-166]
at net.minecraft.server.v1_14_R1.MinecraftServer.executeNext(MinecraftServer.java:1005) ~[patched_1.14.4.jar:git-Paper-166]
at net.minecraft.server.v1_14_R1.IAsyncTaskHandler.awaitTasks(IAsyncTaskHandler.java:119) ~[patched_1.14.4.jar:git-Paper-166]
at net.minecraft.server.v1_14_R1.MinecraftServer.sleepForTick(MinecraftServer.java:989) ~[patched_1.14.4.jar:git-Paper-166]
at net.minecraft.server.v1_14_R1.MinecraftServer.run(MinecraftServer.java:922) ~[patched_1.14.4.jar:git-Paper-166]
at java.lang.Thread.run(Thread.java:748) [?:1.8.0_222]

Getting this error on console when trying up pickup spawners with silk touch.
https://pastebin.com/1SFVJ9u0

• Server version: version git-Spigot-56f8471-43183ea (MC: 1.14.4) (Implementing API version 1.14.4-R0.1-SNAPSHOT)
• Plugin version DEV - 8 (git aded4b1)

Feature Request:
Can you add for change of spawner name to config? and too lore.

Possibly make it so spawners can break on an explosion such as TNT or creepers. Make a percentage chance that the spawner will drop out of 100. Just an idea some of my players have been requesting.

Can you fix this ?

[14:30:56 INFO]: [Core] Checking for 1 updates.[Core] Checking update for Core v0.2.4[PickupSpawners] The spawner breaker item (saved) is null. Please create an issue with the following stacktrace on github.com/poma123/PickupSpawners
[14:30:56 ERROR]: Could not pass event BlockBreakEvent to PickupSpawners vDEV - 8 (git aded4b16)
java.lang.NullPointerException: null
at me.poma123.spawners.Listener.isItemStacksGood(Listener.java:450) ~[?:?]
at me.poma123.spawners.Listener.onSpawnerBreak(Listener.java:587) ~[?:?]
at com.destroystokyo.paper.event.executor.asm.generated.GeneratedEventExecutor344.execute(Unknown Source) ~[?:?]
at org.bukkit.plugin.EventExecutor.lambda$create$1(EventExecutor.java:69) ~[patched_1.15.1.jar:git-Paper-32]
at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:80) ~[patched_1.15.1.jar:git-Paper-32]
at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:70) ~[patched_1.15.1.jar:git-Paper-32]
at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:545) ~[patched_1.15.1.jar:git-Paper-32]
at net.minecraft.server.v1_15_R1.PlayerInteractManager.breakBlock(PlayerInteractManager.java:313) ~[patched_1.15.1.jar:git-Paper-32]
at net.minecraft.server.v1_15_R1.PlayerInteractManager.a(PlayerInteractManager.java:80) ~[patched_1.15.1.jar:git-Paper-32]
at net.minecraft.server.v1_15_R1.EntityPlayer.tick(EntityPlayer.java:363) ~[patched_1.15.1.jar:git-Paper-32]
at net.minecraft.server.v1_15_R1.WorldServer.entityJoinedWorld(WorldServer.java:722) ~[patched_1.15.1.jar:git-Paper-32]
at net.minecraft.server.v1_15_R1.World.a(World.java:878) ~[patched_1.15.1.jar:git-Paper-32]
at net.minecraft.server.v1_15_R1.WorldServer.doTick(WorldServer.java:488) ~[patched_1.15.1.jar:git-Paper-32]
at net.minecraft.server.v1_15_R1.MinecraftServer.b(MinecraftServer.java:1239) ~[patched_1.15.1.jar:git-Paper-32]
at net.minecraft.server.v1_15_R1.DedicatedServer.b(DedicatedServer.java:417) ~[patched_1.15.1.jar:git-Paper-32]
at net.minecraft.server.v1_15_R1.MinecraftServer.a(MinecraftServer.java:1106) ~[patched_1.15.1.jar:git-Paper-32]
at net.minecraft.server.v1_15_R1.MinecraftServer.run(MinecraftServer.java:933) ~[patched_1.15.1.jar:git-Paper-32]
at java.lang.Thread.run(Thread.java:748) [?:1.8.0_232]

Config :
config.txt

Server version 1.15.1 paper 32
PickupSpawners version : pickupspawners-2.9.7-1