polymerelements / iron-a11y-announcer Goto Github PK

On Android with Talkback, the announcements are read 3 times aloud each. Is this intended?

If two messages are announced in quick succession on mac, voiceover only reads the second message. iron-a11y-announcer should probably queue messages and update them at reasonable times so that no messages get dropped.

Generates errors after html2canvas is used on the page in FireFox.

When using this element in FireFox, errors will be generated after the page is rendered by html2canvas.

html2canvas is a common library for generating an image from the DOM:
https://github.com/niklasvh/html2canvas

html2canvas clones the entire document:
https://github.com/niklasvh/html2canvas/blob/master/src/Clone.js#L56

When that is done, a second iron-a11y-announcer element is constructed and begins listening for events on document.body:
https://github.com/PolymerElements/iron-a11y-announcer/blob/master/iron-a11y-announcer.html#L83

At this point there will be multiple iron-a11y-announcer elements listening for announce events, but the second instance will generate exceptions attempting to call 'this.announce()' method.

Expected outcome

iron-a11y-announcer and html2canvas can be used in conjunction.

Actual outcome

iron-a11y-announcer generates errors after html2canvas is used.

Live Demo

http://jsfiddle.net/blois/zvgLtmnd/

Examine console output in FireFox.

Steps to reproduce

1. Put a iron-a11y-announcer element in the page.
2. Open the page in FireFox.
3. load https://github.com/niklasvh/html2canvas
4. html2canvas(document.body)
5. Dispatch an iron-announce event.

Browsers Affected

• Chrome
• Firefox
• Safari 9
• Safari 8
• Safari 7
• Edge
• IE 11
• IE 10

Description

iron-a11y-announcer exposes a 'mode' property that users can use to control the politeness setting, but they can only do this if they create the element themselves and not if they or some other component they use like paper-toast uses requestAvailability.

Expected outcome

Users should be able to control the politeness when using requestAvailability.

Actual outcome

Users cannot control politeness level when using requestAvailability.

With VoiceOver/Chrome: I can't access the text to the right of the announce buttons. Am I supposed to be able to? After reaching the third announce button, I can then access the "hello my name is ava", but the focus ring appears below the buttons and this doesn't seem logical. Same occurs with CHrome OS / Chromevox. I might just be unclear on how this should work though.

Announcer will announce the text 3 times instead of 1.
E.g. Wait a second and you'll hear the text announced 3 times, same happens when clicking on the button http://jsbin.com/bakeqij/2/edit?html,console,output

index.html is not showing anything crome

iron-a11y-announcer.d.ts is missing an entry for the static IronA11yAnnouncer.requestAvailability() method. This was discovered while investigating using TypeScript in Chromium's WebUI codebase, and we had to add this manually for now with the following diff

diff --git a/third_party/polymer/v3_0/components-chromium/iron-a11y-announcer/iron-a11y-announcer.d.ts b/third_party/polymer/v3_0/components-chromium/iron-a11y-announcer/iron-a11y-announcer.d.ts
index b60ac3ba18a0..1646ce15f0f0 100644
--- a/third_party/polymer/v3_0/components-chromium/iron-a11y-announcer/iron-a11y-announcer.d.ts
+++ b/third_party/polymer/v3_0/components-chromium/iron-a11y-announcer/iron-a11y-announcer.d.ts
@@ -34,6 +34,7 @@ declare class IronA11yAnnouncer {
    */
   announce(text: string): void;
   _onIronAnnounce(event: any): void;
+  static requestAvailability(): void;
 }
 
 interface IronA11yAnnouncer extends LegacyElementMixin, HTMLElement {

@usergenic
I believe this file is generated automatically at [1], and therefore possibly a bug in the gen-typescript-declarations tool itself?

[1] https://github.com/PolymerElements/iron-a11y-announcer/blob/master/package.json#L27

I've done a build w/ iron-a11y-announcer 2.0.0 and while it doesn't impact the app the console will throw the error when attempting to append itself to the body of the document. Not sure how it's possible or if there needs to be some checking for body being ready before attempting to append.

Reproducible on demo page.
Clicking any single announce button multiple times in a row will only announce the message once.
Tested on Chrome 53 and Canary.

Per #3 (comment), in ChromeOS, ChromeVox will show a highlight ring around the announcer element and the focused element.

@cdata suggested that we could use some positioning information in the announcer event to make the announcer in the right size/shape to hide the duplicate focus ring.

Announcer won't announce on IE Edge http://jsbin.com/bakeqij/1/edit?html,console,output

Description

When trying to install via Yarn, a version number is required in package.json.

Expected outcome

The package should install without errors.

Actual outcome

error Can't add "@bower_components/iron-a11y-announcer": invalid package version undefined.

Steps to reproduce

1. yarn add PolymerElements/iron-a11y-announcer

Browsers Affected

No browsers affected.