The sf-senla-courses from polashkind

2.2.2 method name - always from small letter

sf-senla-courses/Lecture_2.2/NumberUtility.cls

public static String FibbonachiNum(Integer n){

2.2.1 remove unnecessary comments

sf-senla-courses/Lecture_2.2/Task 2.2.3.cls

    
           // 15. Необходимо написать программу, которая вычисляет числа Фибоначчи в пределах от 1 до N. Число N – объявлено в первой строки скрипта.

2.6.4 move literal to constants

sf-senla-courses/Lecture_2.6/TouristRestService.cls

Line 9 in 49d19e7

Decimal userAge = decimal.valueOf(parameters.get('age'));

2.2.3 Bad paddings

sf-senla-courses/Lecture_2.3/TouristService.cls

Line 1 in bc6fa9e

public class TouristService {

2.2 Each method should return List<Tourist__c>. Remove logic related to Full Name debug logging

sf-senla-courses/Lecture_2.2/Task 2.2.2.cls

Line 15 in 86f2bc5

public static void viewTouristsByAge(Integer filterAge){

2.2.3 empty line before method

sf-senla-courses/Lecture_2.3/TouristService.cls

Line 2 in bc6fa9e

public static void markDuplicates(List<Tourist__c> newTourists) {

2.3.2 Bad naming

sf-senla-courses/Lecture_2.3/TouristAgeTriggerHandler.cls

Line 1 in 8e2334a

public class TouristAgeTriggerHandler {

2.3.2 Move to Constants class

sf-senla-courses/Lecture_2.3/TouristService.cls

Line 27 in bc6fa9e

statusForFlight.get(i).Tourist_Status__c = 'Declined';

2.2.1 empty line before method

sf-senla-courses/Lecture_2.2/Task 2.2.4.cls

Line 2 in 59030bb

public static void markDuplicates(List<Tourist__c> newTourists) {

2.3.2 naming: FlightTrigger

sf-senla-courses/Lecture_2.3/TouristAgeTrigger.trigger

Line 1 in 8e2334a

trigger TouristAgeTrigger on Flight__c (before insert) {

2.7. separate assert block with a line break

sf-senla-courses/Lecture_2.7/TouristManagerTest.cls

Line 10 in eb2e12e

System.assertEquals(1, filteredTourists.size());

2.2.2 Merge to TouristManager

sf-senla-courses/Lecture_2.2/TouristManagerCustom.cls

Line 1 in bc6fa9e

public class TouristManagerCustom {

2.2.2 Naming - getPrimeNumbers

sf-senla-courses/Lecture_2.2/NumberUtility.cls

Line 23 in bc6fa9e

public static List<Integer> numberPrime(Integer toNum) {

2.7. separate assert block with a line break

sf-senla-courses/Lecture_2.7/TouristManagerTest.cls

Line 19 in eb2e12e

System.assertEquals(1, filteredTourists.size());

Move logic to the handler class

sf-senla-courses/Lecture_2.5/TouristTriggerHandler.trigger

Line 8 in 6dd4e77

Set<Id> touristIds = new Set<Id>();

Loop for should be moved to handler class

Please rewrite this class

sf-senla-courses/Lecture_2.5/FlightScheduleJob.cls

Line 1 in b36404d

global class FlightScheduleJob implements Schedulable {

Что-то совсем не то, по сути в методе execute прописан тест для этого класса.
В execute в данном случае должна быть просто строка
Database.executeBatch(new FlightCleanerBatch(), 100);
Понимаешь, что за второй параметр при вызове батча?)

2.6.4 move literal to constants

sf-senla-courses/Lecture_2.6/TouristRestService.cls

Line 8 in 49d19e7

String fuzzyname = parameters.get('fuzzyname');

2.2.2 If methods returns Flights => this method should belong to FlightManager class

sf-senla-courses/Lecture_2.2/TouristManager.cls

Line 21 in bc6fa9e

public static List<Flight__c> getByFlight(Integer filterYear){

Bad requirements

sf-senla-courses/Lecture_2.5/FlightCleanerBatch.cls

Line 3 in 6dd4e77

    
           private static String query = 'SELECT Id, Tourist__r.Name, Tourist__r.Id FROM Flight__c  WHERE Tourist_Status__c = \'Declined\' OR createdDate > LAST_N_DAYS:30';