sf-senla-courses's Introduction
sf-senla-courses's People
sf-senla-courses's Issues
2.2.2 method name - always from small letter
2.2.1 remove unnecessary comments
2.6.4 move literal to constants
2.2.3 Bad paddings
2.2 Each method should return List<Tourist__c>. Remove logic related to Full Name debug logging
2.2.3 empty line before method
2.3.2 Bad naming
2.3.2 Move to Constants class
2.2.1 empty line before method
2.3.2 naming: FlightTrigger
2.7. separate assert block with a line break
2.2.2 Merge to TouristManager
2.2.2 Naming - getPrimeNumbers
2.7. separate assert block with a line break
Move logic to the handler class
Loop for should be moved to handler class
Please rewrite this class
Что-то совсем не то, по сути в методе execute прописан тест для этого класса.
В execute в данном случае должна быть просто строка
Database.executeBatch(new FlightCleanerBatch(), 100);
Понимаешь, что за второй параметр при вызове батча?)
2.6.4 move literal to constants
2.2.2 If methods returns Flights => this method should belong to FlightManager class
Bad requirements
WHERE Tourist_Status__c = 'Declined' AND createdDate > LAST_N_DAYS:30
Проблема не ваша, а требований, некорректно написано)
2.2.1 only new Tourists should be marked as duplicates
2.6.4 move literal to constants
2.2.2 naming - isPalindromNumber (because returns Boolean)
2.3.2 All SOQL to Managers
2.2 Naming - getByNames(...)
2.3.2 This method should support List of Tourists
If statement
If I right understand you also should check if newTourist.Id != existingTourist.Id
2.7. all live methods must be covered
2.6.4 move SOQL to manager
2.2 Take DML-operationd out of loops
2.3.2 DML inside loop is forbidden
2.6.4 search therm could be a part of name
2.2.2 getByEmailLastName - but you just query All the Tourist without any filters. Add filters (names, emails)
2.3.2 fix logic error - you should not update Flights from other Tourists
2.7. to improve: this and the next line move to @TestSetup or static
2.2.1 L24-27 simplify
2.2.1 All SOQL requests should belong to Managers classes (like TouristManager)
2.2 You should compare newTourists with existing ones (select from DB)
2.3.2 Trigger should work with TriggerHandler
2.4.1 Padding = 4 spaces
2.3.2 Bad naming: flightAge -> flights
2.7. to improve: this and the next line move to @TestSetup or static
2.3.2 use for-each loop
2.3.2 Several triggers on one SObject is forbidden!
2.3.2 Empty line before method
2.2.1 All Classes from capital letter: String, Boolean, etc.
2.3.2 This implementation is not working.
2.2 all the methods should return some values
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.