pocketrent / beatbox Goto Github PK

There's a race condition in Cache.php in the get_or_set method:

• you first test the key,
• then you get its value.

If the cache entry expires in-between the two, you've hit the race condition.

The solution would be to remove the call to test, you should call get and if it returns null then set else return.

Opening an issue for a commit comment to make sure it doesn't get lost.

        self::redis()->set($key, $value, $expire);
        if (self::redis()->exists($key)) {
            self::add_tags($key, $tags);
        }

It will result on 2 (slow) IO operations, right ?
couldn't the if condition be based on $expire only ?

I'm unsure if wrapping test/get in a transaction really solves #3.

The expiration can still happen in between test & get, what do you think ?

What about the proposed solution ?