pmassing / auler.gmbh.zugferdxinvoice

ReadMe

Plugin-Name: ZugferdXInvoice for iDempiere (auler.gmbh.zugferdxinvoice)

Plug-in Version: 1.0

Status: Testing/Pre-Release

Licence: GPLv2

Author: Patric Massing (Hans Auler GmbH), Germany, p.massing(at)auler.gmbh

Date: 2022

Environment: iDempiere 10

Used libraries: mustangproject library (License Apache 2.0), mustangproject validator (License Apache 2.0)

This Plug-in is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details.

Description This plugin provides a process in iDempiere to create a ZUGFeRD/X-Invoice PDF-file as attachment of Invoice-Record and provides the PDF-file as Download.

Detailed Dokumentation is on iDempiere Wiki

auler.gmbh.zugferdxinvoice's Issues

Add C_UOM.UNCEFACT

Instead of using the X12DE355 code which is still required for EDI, it would be better to add a C_UOM.UNCEFACT column.

UN/CEFACT is the code used for ZUGFeRD

This can be discussed with community as must be better to be added in core

xref https://idempiere.atlassian.net/browse/IDEMPIERE-6068

Upgrade to mustang 2.10.0

https://www.mustangproject.org/mustang-2-10-0/

Apply some best practices

Avoid error -> Document not posted

The auler.gmbh.zugferdxinvoice.process.ZUGFeRD.createInvoice is throwing error "Document not posted !" when the document is not posted.

The posting must not be an impediment to print the invoice as this usually happens later (or it doesn't happen at all in some implementations without accounting).

The only case where it would be required is when the invoice printout includes information from Fact_Acct.

For that we propose to create a SysConfig ZUGFERD_ERROR_IF_NOT_POSTED to enable that when required.

Generate ZUGFeRD invoices automatically

Proposal here is to implement some way to generate ZUGFeRD invoices automatically when generating an iDempiere invoice, this is, to avoid the need to run an additional process.

For this I think we can do the following changes:

1. Use the default bank account for the invoice organization (there can be other possibilities here if needed, using the default is just the easiest)
2. Add a flag in C_DocType.IsZUGFeRD to indicate that this document must be processed by the ZUGFeRD process
3. On the core side we would need to add some sort of post-process, I think maybe an EventHandler for post-generate-pdf can be helpful, this EventHandler could pass as parameters AD_Table_ID, Record_ID and the PDF file, the handler post-processes the file (for example attaching the ZUGFeRD in this case, but it could be also used to add PDF signature for example) and returns the modified PDF IDEMPIERE-6069