plumming / dx

Only use this repo if you have the chillies

DX

Installation via Homebrew

To install dx using homebrew, run the following:

brew tap plumming/homebrew-tap
brew install dx

Basic Usage

View a list of Open PRs

dx get prs

Configure the list of repos to watch

dx edit config

Add more entries under the repos: block e.g.

repos:
- org/repo1
- org/repo2

Exclude PRs based on labels

dx edit config

hiddenLabels:
- wip
- do not merge

Exclude PRs older than X days

dx edit config

maxAgeOfPRs: 180

or for all PRs

maxAgeOfPRs: -1

Rebase the local repository

This will rebase the local repository against the remote called 'upstream'.

dx rebase

Commands

• dx
• dx context
• dx delete
• dx delete repos
• dx edit
• dx edit config
• dx get
• dx get issues
• dx get prs
• dx get repos
• dx get security-config
• dx get vulnerability-alerts
• dx import
• dx import context
• dx namespace
• dx rebase
• dx shell
• dx upgrade
• dx upgrade cli

dx's Issues

Allow option to run against current directory git repo

Something like:
chilly get prs --here
or
chilly get prs .

Question: does `dx get prs --retrigger` make sense anymore?

Migrate chilly config to dx config for existing users

Add the ability to view security advisories for all configured repos

As an initial query something like:

{
	search(type:REPOSITORY, query: "repo:plumming/dx repo:jenkins-x/go-scm", first: 100) {
      nodes {
      ... on Repository {
        nameWithOwner
        vulnerabilityAlerts(first: 10) {
          totalCount
          nodes {
            securityAdvisory {
              ghsaId
              severity
              summary
            }
            state
            createdAt
            dependabotUpdate {
              pullRequest {
                number
              }
            }
          }
        }
      }
    }
  }
}

would do the job, filtering on all those issues that are state != "FIXED", optionally showing those advisories where a dependabot PR exists that can fix it.

Should `dx get prs --me` use `involves` rather than `author`?

When requesting my PRs, it may make sense to use the search query involves:xxx rather than author:xxx.

Would this be a better experience?

This can be tested using the command

dx get prs --raw involves:xxx

`dx rebase` should warn/error if origin & upstream are the same

Question: does the `dx get prs --review` flag make sense anymore?

Add support for other scm providers

It would be good to support gitlab.com and internal installs of gitlab, if we could do this, what commands could we support? Should we only support providers that provide a graphql endpoint to reduce traffic?

Config

How would we restructure the configuration to support different SCM types?

repositories:
- name: github.com
  kind: github
  repos:
  - plumming/dx
- name: github.myenterprise.com
  kind: github
  repos:
  - xxx/something
- name: gitlab.com
  kind: gitlab
  repos:
  - another/repo

dx get prs

GitLab refers to them as MRs, so adding that as an alias would make sense. I can't find a graphql query to do this in a single shot, may have to perform a request per repository. The following query may be enough to extract enough data for PRs.

{
  project(fullPath: "org/repo") {
    mergeRequests(first:50, state:opened) {
      nodes {
        iid
        title
        labels {
          nodes {
            title
          }
        }
        mergeable
        conflicts
        createdAt
        author {
          name
        }
        approvalsRequired
        approvalsLeft
      }
    }
  }
}

Become verified apple developer

Current installation process of downloading the binary and adding to path doesn't work out of the box for MacOS Catalina. Stricter rules mean that trying to run chilly from a fresh download prompts the following error:

"chilly" cannot be opened because the developer cannot be verified

So one has to control + click -> open the file in finder, approve running it, in order to execute the binary (or mess with security settings to allow all unknown developer apps to be opened).

Handle `--force-with-lease` when rebasing

Could be an optional parameter? Or use it all the time?

do not display auth header in debug logs

Title bar on `get results`

I don't know what the * ? at the end of each row means. Worth highlighting with titles (which can be flagged/configured off)

Use spf13/afero for file system interactions

Add a `dx get issues` command

It would be nice to be able to view all open issues across the configured repositories

`dx` should create its own auth token in `~/.config/dx/config.yaml` rather than use gh

show how many PRs have been filtered from the current view

if filtered > 0, where the filtered PRs are based on bot accounts / labels etc.

Should display something like:

N PR(s) have been filtered from this list, use --show-bots to view them

Switch kube namespace cmd

Make it easy to generate a config file from a list of repositories

Can we show the number of comments/replies to an issue/pr?

`dx ns` does not currently work against GCP clusters

FATAL: unable to run command: validate failed: failed to select namespace: while loading namespaces: failed to create kube client: no Auth Provider found for name "gcp"

`dx rebase` does not work if repos are cloned via an SSH url

Error is: first path segment in URL cannot contain colon

`dx rebase` does not work on github enterprise

Auth has been hardcoded to use github.com

goreleaser should use bot user

https://github.com/plumming/dx/blob/master/.goreleaser.yml#L150

`dx context` should take an optional arg with the context to switch to

e.g. dx context my-context

`dx ns` should take a namespace as a single arg

strip newlines/tabs from graphql query before sending to github

Allow chilly to be installed via homebrew

display the number of PRs in view in the row at the base

Showing 17 PR(s), Filtered .....

Favour cobra RunE over Run

❯ grep -R "Run: func" *
cmd/dx/dx.go:	Run: func(cmd *cobra.Command, args []string) {
cmd/dx/dx.go:	Run: func(cmd *cobra.Command, args []string) {
pkg/cmd/editcmd/edit_config.go:		Run: func(cmd *cobra.Command, args []string) {
pkg/cmd/editcmd/edit.go:		Run: func(cmd *cobra.Command, args []string) {
pkg/cmd/upgradecmd/upgrade_cli.go:		Run: func(cmd *cobra.Command, args []string) {
pkg/cmd/upgradecmd/upgrade.go:		Run: func(cmd *cobra.Command, args []string) {
pkg/cmd/rebasecmd/rebase.go:		Run: func(cmd *cobra.Command, args []string) {
pkg/cmd/deletecmd/delete.go:		Run: func(cmd *cobra.Command, args []string) {
pkg/cmd/deletecmd/delete_repos.go:		Run: func(cmd *cobra.Command, args []string) {
pkg/cmd/importcmd/import.go:		Run: func(cmd *cobra.Command, args []string) {
pkg/cmd/importcmd/import_context.go:		Run: func(cmd *cobra.Command, args []string) {
pkg/cmd/getcmd/get_repos.go:		Run: func(cmd *cobra.Command, args []string) {
pkg/cmd/getcmd/get_prs.go:		Run: func(cmd *cobra.Command, args []string) {
pkg/cmd/getcmd/get_issues.go:		Run: func(cmd *cobra.Command, args []string) {
pkg/cmd/getcmd/get.go:		Run: func(cmd *cobra.Command, args []string) {
pkg/cmd/namespacecmd/namespace.go:		Run: func(cmd *cobra.Command, args []string) {
pkg/cmd/contextcmd/context.go:		Run: func(cmd *cobra.Command, args []string) {

message at the end of `dx ns` needs a line feed

Current implementation of `manager_test.go` is really bad

It currently just calls the functions and expects them not to fail. It should assert something but i was having issues working out how to stub out the exec.LookupPath function

Make the max number of PRs configurable

At the moment this is hardcoded to 100, we should make this configurable in the config

`dx rebase` should handle newly created files

touch ll && dx rebase

will currently fail as the command detects local changes, this should not be the case.

`dx ns <namespace>` allows you to select a namespace that does not exist

Add a `dx delete context` command

Automate generation of command docs

Instructions to upgrade dx are incorrect

If brew is installed, and dx is listed in brew list then we should prompt to use the brew upgrade dx command rather that dx upgrade cli

`dx rebase` should still function if no upstream is set

Show which repositories have vulnerability alerts configured.

{
	search(type:REPOSITORY, query: "...", first: 100) {
      nodes {
      ... on Repository {
        nameWithOwner
        url
        hasVulnerabilityAlertsEnabled
      }
    }
  }
}

PR comments should also include the reviews & review comments count

Add to search query

reviews(first: 100) {
          totalCount
          nodes {
            comments {
              totalCount
            }
          }
        }

Conclusions can have an ERROR state

This is currently coming back as success.

Rather than filtering `dependabot` PRs, we should allow a configurable list of bot users to exclude by default

Then use the flag --show-bots to enable all bot users.

This should appear in dx edit config with the defaults set to dependabot & dependabot-preview

Change name to dx

change all references of chilly to dxin:

• go files
• github actions
• brew