Coder Social home page Coder Social logo

WAVE test failing about antispam-bee HOT 4 CLOSED

Zodiac1978 avatar Zodiac1978 commented on August 16, 2024
WAVE test failing

from antispam-bee.

Comments (4)

rianrietveld avatar rianrietveld commented on August 16, 2024 1

@Zodiac1978 hidden refers to type="hidden" and in this case it's a textarea :-)

from antispam-bee.

Zodiac1978 avatar Zodiac1978 commented on August 16, 2024

Thank you very much @rianrietveld !

I am still confused, because WAVE is telling us (emphasize from me):

Labels are not required for image, submit, reset, button, or hidden form controls.

Therefore the label shouldn't be required here, or not?

@2ndkauboy Any chance to get this in, even it is already in the comment form?

from antispam-bee.

Zodiac1978 avatar Zodiac1978 commented on August 16, 2024

We could just add this here:

https://github.com/pluginkollektiv/antispam-bee/blob/master/antispam_bee.php#L1281

What about using hp-comment as the aria-label (for "honeypot comment" but not too much "telling")

from antispam-bee.

Zodiac1978 avatar Zodiac1978 commented on August 16, 2024

Adding more details (emphasize mine):

… text input that is hidden with aria-hidden=”true” and tabindex=”-1″. This field does not appear to be presented to users, so the error can be ignored
In WAVE we have chosen to identify potential errors and issues with all page elements, even if they are hidden. We’ve found that in the vast majority of cases where hidden elements have identifiable issues, these issues are at some point presented to end users (such as via dynamic page changes, by the user disabling styles, etc.). We know that there are sometimes exceptions (such as yours) where hidden elements may not be presented to users via aria-hidden and/or tabindex. In the somewhat rare cases where such elements are hidden in an accessible manner, they can often be removed entirely from the page or the accessibility can readily be added to them. In your case if you can add aria-hidden and tabindex, then it’s probably reasonable to assume you can also add a or aria-label to address the detectable error pattern.

From: https://equalentry.com/equal-entry-website-mistakenly-called-out-as-inaccessible/

TL;DR: Error can be ignored, but the error can easily be prevented if we add the label, what the PR is doing.

from antispam-bee.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.