Coder Social home page Coder Social logo

lewreorderablelayout's People

Contributors

pljhonglu avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar

lewreorderablelayout's Issues

iOS 11 offset wrong

in iOS 11, dragging a cell to the top or bottom will not fully move the scrollview towards the end.

手势冲突的小问题

如果某一行没有填满, 那么想要拖动整个view则会被gesture的delegate阻止掉, 导致这一部分拖动事件无法响应, 例如, 大图这一行个数的单数的情况下, 拖动右边的空白区域是无效的.
建议:

- (BOOL)gestureRecognizer:(UIGestureRecognizer *)gestureRecognizer shouldRecognizeSimultaneouslyWithGestureRecognizer:(UIGestureRecognizer *)otherGestureRecognizer{
if ([_panGesture isEqual:gestureRecognizer]) {
        if ([_longPress isEqual:otherGestureRecognizer]) {
            return YES;
        }else{
            // 这里原来直接返回NO, 可以根据是否选中了cell来判断
            CGPoint location = [gestureRecognizer locationInView:self.collectionView];
            return ![self.collectionView indexPathForItemAtPoint:location];
        }
....
}

Lack of comments

As delegate methods are optional, please add comments with default value (if not implemented) to interface

section留下最后一个cell的时候无法移动

看了代码是直在canMove里面返回了NO, 但是这样一来的话, 会导致既不能往下移, 也不能往上移了. 建议添加一个delegate方法来获取是否需要继续移动的操作. 在longPressBegan的case里面先检查这个

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.