playnetwork / playnetwork-sdk-nodejs Goto Github PK

when JSON.parse(body) has an invalid respone the options for makerequest should be included in the err object to provide insight into failing request.

currently blocking usage of getAssetStream call with ‘join is not defined’.

Simply reversing, join and parts fixes the issue.

TypeError: self.player.settings is not a function
at Object.self.options (/Users/tsmith/Projects/provision-svc/node_modules/playnetwork-sdk/lib/index.js:53:25)

https://github.com/PlayNetwork/playnetwork-sdk-nodejs/blob/develop/lib/index.js#L53

In order to handle situations where not every parameter is passed in to the deleteSettings and getSettings functions, an attempt is made to determine which parameter is a function, and use that as the callback. trouble is, callback is set to settingId which is a variable that is never declared, so callback will still be undefined by the time we try to use it.