pkuehne / node-id3 Goto Github PK
View Code? Open in Web Editor NEWThis project forked from zazama/node-id3
Pure JavaScript ID3 Tag library
License: MIT License
This project forked from zazama/node-id3
Pure JavaScript ID3 Tag library
License: MIT License
The function getTagsFromBuffer
does a lookup on the encoding byte to get the name of the encoding scheme, this is already implemented in getEncodingName
and should be used instead:
instead of
let decoded
if(frame.body[0] === 0x01) {
decoded = iconv.decode(frame.body.slice(1), "utf16").replace(/\0/g, "")
} else {
decoded = iconv.decode(frame.body.slice(1), "ISO-8859-1").replace(/\0/g, "")
}
it should be just
const encodingName = getEncodingName(frame.body[0])
const decoded = iconv.decode(frame.body.slice(1), encodingName).replace(/\0/g, "")
See this PR on the upstream repo
Simply create a class and pull all functions in as member functions.
There is an options parameter that can be passed to the read
function, which is never used either by read
or getTagsFromBuffer
. Remove it and the convoluted optionality code to set fn
.
Functions like read
and write
take an fn
parameter as a callback. Instead these functions should return a Promise.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.