Coder Social home page Coder Social logo

pragma's People

Contributors

alexandrafo avatar amirzoian avatar asmecher avatar bolelligallevi avatar bozana avatar bsvvi avatar ckamburov avatar defstat avatar dependabot[bot] avatar diegojmacedo avatar jirrka avatar jordilacruz avatar josekarvalho avatar kant avatar mandroide avatar marcbria avatar mhvezina avatar mirkospiroski avatar mooselybased avatar mtub avatar natewr avatar neffe avatar osmndrmz avatar ppv1979 avatar primoz-svetek avatar sssoz avatar t-fildishevska avatar tigran54 avatar vitaliy-1 avatar vormia avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

pragma's Issues

Support for categories

The theme doesn't support styling for the catalogCategory page yet. It requires overriding templates/frontend/pages/catalogCateogy.tpl with theme-specific markup and additional styling if necessary.

Accessibility issues with the announcements carousel

The carousel used for the announcements (see this demo) has a couple issues that probably need to be addressed for accessibility.

  1. When using the keyboard to focus on the prev/next buttons and then hitting enter, focus is dropped. It needs to stay on the same prev/next button. It looks like this is the case with the default bootstrap4 carousel.

  2. There's no indication of what the buttons control. I'm not sure what the correct approach is here. With the pagination component I've used aria-live="polite". But I think that only works because the content is being replaced. Since the carousel works by selectively showing/hiding things, I'm not 100% sure that aria-live="polite" will signal the change to the user. In this inclusive carousel component article he suggests using something like this:

<div role="region" aria-label="Announcements" aria-describedby="instructions">
  <!-- slides -->
  <div id="instructions">
    <!-- prev/next buttons -->
  </div>
</div>

I'm not totally sure that nails our use case, and sometimes poorly applied aria can be worse than no aria, but I'm not aware of a better alternative here. These kinds of controls are tricky.

Of course, the other option is to get rid of the carousel and simply put one announcement up with a "View All Announcements" link.

Full Issue Galley aren't being displayed

Describe the bug
The full issue galley file uploaded in Issue > Issue Galleys does not appear on the front end. Tested on OJS 3.3.x

To Reproduce
Steps to reproduce the behavior:

  1. Go to Issues
  2. Click on Issue followed by Edit
  3. Go to Issue Galleys
  4. Create Issue Galley and upload file

Expected behavior
Full issue galley PDF should appear on Journals Front end (Homepage and/or TOC landing page)

Screenshots
image

image

image

Desktop (please complete the following information):

  • OS: MacOS Monterey 12.4
  • Browser: Chrome
  • Version 103.0.5060.24

Style article detail page

Make sure to have all elements in article page:

  • Article title
  • DOI
  • Pub IDs
  • Issue title
  • Issue section (to which article belongs)
  • Volume info (number and title, if there is one)
  • Date / time published (article AND / OR issue publishing date - because they can be different)
  • Page numbers
  • Authors
  • Authors’ affiliations
  • Authors’ bios
  • Article image
  • Abstract
  • References
  • Galley links
  • Supplemental galley links
  • Keywords
  • How to cite
  • Licensing info (copyright holder & year)

Dropdown menu doesn't work on a pdf article page

The Dropdown menu – for example the "about" on the demo page: https://demo.publicknowledgeproject.org/ojs3/demo/index.php/pragma/issue/view/46 – works fine, but on the pdf article page – like this one: https://demo.publicknowledgeproject.org/ojs3/demo/index.php/pragma/article/view/977/512 – it does not work.

Steps to reproduce the behavior:

  1. Go to https://demo.publicknowledgeproject.org/ojs3/demo/index.php/pragma/issue/view/46
  2. Click on 'About', the dropdown menu works fine
  3. Go to https://demo.publicknowledgeproject.org/ojs3/demo/index.php/pragma/article/view/977/512
  4. Click on 'About', the dropdown menu does not drop down!

Expected behavior
The Menu is supposed to drop down, even on the pdf page.

  • Browsers: I've tested it on Chrome, Safari, Opera, Edge, with the same effect.

It's as if the pdf.js was blocking the script for the dropdown menu.

Style & template general + informational pages

Make sure to:

  • Only stick to Bootstrap 4 and BEM classes
  • Pay attention to semantic markup, and screen reader-friendly HTML
  • Break up stylesheets into single block component per file, and keep blocks simple

TODO:

General pages

Informational pages

The site index’s journal loop does not work

See this fix from the default theme: pkp/ojs@f4cf12c.

The count($journals) in the site-wide index template didn't work. So you'll want to update your templates to use $journals->wasEmpty().

Also, the pagination can be removed because all journals are delivered to the template. There's no second page.

Affiliation button doesn't work

OJS 3.2.0-2
Article landing page.
Pressing on the affiliation button returns an error:

Uncaught TypeError: Cannot convert object to primitive value
    at RegExp.test (<anonymous>)
    at HTMLDivElement.<anonymous> (app.min.js?v=3.2.0.2:1)
    at Function.each (app.min.js?v=3.2.0.2:1)
    at y.fn.init.each (app.min.js?v=3.2.0.2:1)
    at y.fn.init.t._jQueryInterface [as collapse] (app.min.js?v=3.2.0.2:1)
    at HTMLDivElement.<anonymous> (app.min.js?v=3.2.0.2:1)
    at Function.each (app.min.js?v=3.2.0.2:1)
    at y.fn.init.each (app.min.js?v=3.2.0.2:1)
    at HTMLButtonElement.<anonymous> (app.min.js?v=3.2.0.2:1)
    at HTMLDocument.dispatch (app.min.js?v=3.2.0.2:1)

Section Policy is recendering with html tags (OJS 3.3.0.8)

Describe the bug
Text entered into the Section Policy WYSIWYG editor is rendered as source code (with html tags instead of proper formatting). The problem is isolated to the Section Policy -- all other textboxes appear as expected. Toggling to other Themes resolves the issue, so our guess was that there is a bug within the Pragma plugin?

Pragma was working well while we were using OJS 3.2.1.4, but broke after we upgraded to 3.3.0.8.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Journal Settings > Sections > Edit > Populate Section Policy textbox with content
  2. Navigate to reader view > Submissions > Scroll down to Sections

Screenshots
image

Desktop (please complete the following information):

  • OS: Windows10
  • Browser: can be replicated using Firefox, Chrome, and MSEdge
  • OJS Version: 3.3.0.8.
  • Pragma Version: 1.1.0

Missing image for JQuery UI

Images for JQuery UI, on which tag-it depends, are missing. See console error on the registration page. All themes are affected excluding the Default.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.