pkp / customlocale Goto Github PK

Currently users need to do some digging before they'll know what file to edit using the Custom Locale Plugin to tweak some text.

See: https://forum.pkp.sfu.ca/t/ojs-and-customlocale-plug-in/61853/2

It would be much easier if there was a search tool in the Custom Locale Plugin to help users identify which file they needed to edit in order to change a piece of text.

Hello!

As the title says, the plugin doesn't allow editing empty translation strings, like this one in pkp-lib/locale/es/emails.po:

msgid "emails.footer.unsubscribe"
msgstr ""

I know, the best approach would be contributing untranslated strings, but in the meantime we need a fix for these tags being sent to the users now. As a quick fix I had to add them to the emails.po file but they'll be removed with the next update.

Also, I've checked the pkp-lib's Weblate project and currently there isn't a section for this emails.po file, the Spanish translation is shown as complete.

So the empty strings aren't shown in the UI for translation. May this option be added for future fixes?

Regards!

This plugin does not currently have CSRF checking.

It's needed to update the migration file due to the merge of localization folders.

A migration for the 3.4 already exists (it's working with a "lock file" as we don't have access to the previous/current version at the moment the code is called):
https://github.com/pkp/customLocale/blob/579c394dedbcfb084d0466bdf32372bcc8794a0e/classes/migration/upgrade/v1_2_0/I15_LocaleMigration.php

• Also, at this moment the build is broken with the message: CypressError: cy.click()can only be called on a single element. Your subject contained 2 elements. Pass{ multiple: true } if you want to serially click each element. Fixed by #24

I saw the method below on the defaultTranslation plugin, and I think it makes sense to have it on this plugin as well, in order to ensure it's loaded/registered before other plugins:
https://github.com/pkp/defaultTranslation/blob/425fee0880efc7782196b3e8e8e68aab9bdf3ca5/DefaultTranslationPlugin.php#L60-L66

PRs

• main
• #19
• stable-3_3_0
• #20

The #12 was slightly outdated when it was merged and requires minor updates to get into a working state.

PR

• #16

Setup:

• customLocale v1_1_0-1
• PHP 7.4
• OJS 3.3.0-6
• Windows 10

Installed by extracting tar into <ojs>/plugins/generic/

[Tue May 18 16:17:05.276134 2021] [php7:error] [pid 6576:tid 1088] [client ::1:63979] PHP Fatal error:  Uncaught Error: Call to a member function getId() on null in D:\\ApacheHosted\\ojs\\plugins\\generic\\customLocale\\CustomLocalePlugin.inc.php:32\nStack trace:\n#0 D:\\ApacheHosted\\ojs\\lib\\pkp\\classes\\plugins\\PluginRegistry.inc.php(69): CustomLocalePlugin->register('generic', 'plugins/generic...', NULL)\n#1 D:\\ApacheHosted\\ojs\\lib\\pkp\\classes\\plugins\\PluginRegistry.inc.php(142): PluginRegistry::register('generic', Object(CustomLocalePlugin), 'plugins/generic...', NULL)\n#2 D:\\ApacheHosted\\ojs\\lib\\pkp\\classes\\core\\Dispatcher.inc.php(133): PluginRegistry::loadCategory('generic', true)\n#3 D:\\ApacheHosted\\ojs\\lib\\pkp\\classes\\core\\PKPApplication.inc.php(362): Dispatcher->dispatch(Object(Request))\n#4 D:\\ApacheHosted\\ojs\\index.php(68): PKPApplication->execute()\n#5 {main}\n  thrown in D:\\ApacheHosted\\ojs\\plugins\\generic\\customLocale\\CustomLocalePlugin.inc.php on line 32

Currently the custom locale plugin only allows editing of the journal's primary locale. For users with other locales, it's necessary to work around this by temporarily setting the primary locale to the other locale.

Improve the plugin's ability to work with other languages without requiring the work-around.