pkp / bootstrap3 Goto Github PK
View Code? Open in Web Editor NEWA community-built theme for OJS 3 that implements Bootstrap 3 components.
License: GNU General Public License v3.0
A community-built theme for OJS 3 that implements Bootstrap 3 components.
License: GNU General Public License v3.0
Hi everyone,
first of all: thanks a lot for these themes. They look and feel pretty nice. :)
However, I'd like to know if it is possible to mark required form fileds (e.g. for user registration) or if this could be taken into the next release. I know that these themes "may not support all features of OJS 3.0", but perhaps this might be useful for all users.
Kind regards
Dennis
Logos in headers are not properly resized.
In order to register as a user in OJS 3.1.1 you have to agree to the terms of the privacy statement. However, this is missing from: templates/frontend/components/registrationForm.tpl in this theme. Quick copy-and-paste required.
could you implement an option in the OJS 3 appearance panel to set the size of the journal logo? the bootstrap themes simply scale it down to a very small image.
It seems as if there's some code missing in BootstrapThreeThemePlugin.inc.php. At least in my test environment Bootstrap3 Theme doesn't load any menu items. A quick check with the Default Theme Plugin points to a missing line at the bottom of init().
$this->addMenuArea(array('primary', 'user'));
I added it manually in my environment and it gave me the missing menu items back.
Hi ,
Is it possible to implement right to left support for for Arabic , Hebrew , Persian languages . the current version looks not supporting that .
This didn't get reviewed and merged during the sprint.
{**
* templates/frontend/pages/indexSite.tpl
*
* Copyright (c) 2014-2016 Simon Fraser University Library
* Copyright (c) 2003-2016 John Willinsky
* Distributed under the GNU GPL v2. For full terms see the file docs/COPYING.
*
* Site index.
*
*}
{include file="frontend/components/header.tpl"}
<div id="main-content" class="page page_indexSite">
{if $intro}{$intro|nl2br}{/if}
<a name="journals"></a>
{iterate from=journals item=journal}
{if $site->getSetting('showThumbnail')}
{assign var="displayJournalThumbnail" value=$journal->getLocalizedSetting('journalThumbnail')}
<div style="clear:left;">
{if $displayJournalThumbnail && is_array($displayJournalThumbnail)}
{assign var="altText" value=$journal->getLocalizedSetting('journalThumbnailAltText')}
<div class="homepageImage"><a href="{url journal=$journal->getPath()}" class="action"><img src="{$journalFilesPath}{$journal->getId()}/{$displayJournalThumbnail.uploadName|escape:"url"}" {if $altText != ''}alt="{$altText|escape}"{else}alt="{translate key="common.pageHeaderLogo.altText"}"{/if} /></a></div>
{/if}
</div>
{/if}
{if $site->getSetting('showTitle')}
<h3>{$journal->getLocalizedName()|escape}</h3>
{/if}
{if $site->getSetting('showDescription')}
{if $journal->getLocalizedDescription()}
<p>{$journal->getLocalizedDescription()|nl2br}</p>
{/if}
{/if}
<p><a href="{url journal=$journal->getPath()}" class="action">{translate key="site.journalView"}</a> | <a href="{url journal=$journal->getPath() page="issue" op="current"}" class="action">{translate key="site.journalCurrent"}</a> | <a href="{url journal=$journal->getPath() page="user" op="register"}" class="action">{translate key="site.journalRegister"}</a></p>
{/iterate}
{if $journals->wasEmpty()}
{translate key="site.noJournals"}
{/if}
<div id="journalListPageInfo">{page_info iterator=$journals}</div>
<div id="journalListPageLinks">{page_links anchor="journals" name="journals" iterator=$journals}</div>
</div><!-- .page -->
{include file="common/frontend/footer.tpl"}
Registered user's email function not working with bootstrap them (we get this error : No user exists with the specified email address.) . but when i changed the theme to the default it is working fine.
Im using ojs 3:
http://sportuniversity.org/sport/index.php/ijaep/login/lostPassword
You may check by registering and then reset. if need i can send you account detail for journal manager.
Thank You
If I enable ReCaptcha but switch to this theme, the captcha won't display on user register. The following code should be added to templates/frontend/pages/userRegister.tpl:
{if $reCaptchaHtml}
<fieldset class="recaptcha_wrapper">
<div class="fields">
<div class="recaptcha">
{$reCaptchaHtml}
</div>
</div>
</fieldset>
<br />
{/if}
... maybe around line 77. I've already made this fix to a current journal; I'm super rusty in the whole pull request business, but if that helps I can try to send one.
Fix here ubbdst/ojs@b5b21e3
I'm unclear how this theme would be customised, i.e. with changes to the CSS, JS and layout (templates). Where would overriding custom styles (CSS, less?) templates etc. go, assuming the base theme is to remain upgrade-safe?
Or is that not possible?
I noticed the site name is wrapped in a <h1>
element. That is poor practice for a number of reasons.
The <h1>
element should present the title of the page, not the site. The <h1>
page name is usually used in search results, and so ranks very low if all pages are the same.
This was even pointed out by the design lead of the gov.uk
sites when he gave a talk on accessibility last month - screen readers put a lot of emphasis on the header element structure of the page, and is the main navigation used for skipping sections of the page, so that first <h1>
needs to tell the site visitor what that page is all about.
Additionally, when the site title is replaced with an image, the <h1>
element does not even contain any text.
The current logic doesn't seem to check for a current context. It should look like https://github.com/pkp/pkp-lib/blob/master/templates/frontend/components/header.tpl#L73-L90
This is one example, I think there are one or two more on this page. I believe they have already been removed from the original core PKP-lib template files. They cause unnecessary
spaces between text components (eg. between list items or paragraphs).
I removed the required classes/ids. Woops.
a new user attempting to create a user account reports filling out the account information, but when they click ‘submit’, the page refreshes, and fails to create the user account.
We use {url|assign...
and {translate|assign...
throughout the theme. This will not longer be valid Smarty once the upgrade to v3 is merged in (pkp/pkp-lib#3242).
We need to use {capture}
instead. But we also need to be careful to not introduce white-space that can cause conditional errors, like the $prevUrl
and $nextUrl
issue that @vitaliy found: pkp/pkp-lib#3652
Hi,
I followed the instructions and extracted the plugin into the themes folder. I get the following error now when I click on the "System Plugins" link:
Fatal error: require_once(): Failed opening required 'lib/pkp/classes/plugins/ThemePlugin.inc.php' (include_path='.:/home/scipie/public_html/classes:/home/scipie/public_html/pages:/home/scipie/public_html/lib/pkp:/home/scipie/public_html/lib/pkp/includes:/home/scipie/public_html/lib/pkp/classes:/home/scipie/public_html/lib/pkp/pages:/home/scipie/public_html/lib/pkp/lib/adodb:/home/scipie/public_html/lib/pkp/lib/phputf8:/home/scipie/public_html/lib/pkp/lib/pqp/classes:/home/scipie/public_html/lib/pkp/lib/smarty:.:/usr/lib/php:/usr/local/lib/php') in /home/scipie/public_html/lib/pkp/includes/functions.inc.php on line 25
I'm running this vagrant version of OJS 3 https://github.com/mjordan/pkppln_vagrant but when trying to install the bootstrap plugin or any plugin for that matter I get a permissions error. I've tried both at work and on my personal laptop at home...no go either way.
The citation formats are delivered to the theme in a different way now and there's a different URL for fetching each format.
On the article details page, article authors are not separated (e.g. via a ',') and multiple authors simply flow together in a single string.
It was modified heavily for OJS 3.
Add support for displaying versions and the version notice on the article view page once it makes it into master.
Re: this line: https://github.com/NateWr/bootstrap3/blob/ec6409f2e06a51debded989c0b641fcb9fb2a152/styles/bootstrap.less#L224
I think it can be changed to:
#pdfCanvasContainer, #htmlContainer {
... and all will be well. :-)
Hola a todos,
he creado este Issues porque tengo problemas para modificar el theme creado por @NateWr y su equipo. podrían hacer un ejemplo sobre como agregar una imagen de fondo en el header y agregar un menú lateral lado izquierdo.
para mortales¡¡¡¡
A number of recent and pending changes in OJS master require changes for this theme:
userRegister.tpl
with some updates to the role selection process. pkp/pkp-lib#1443Several pieces of data on article details are missing, most of which aren't working in master. These will need to be added when available:
Article detail elements
Summary section
Article tools (maybe in sidebar?)
Displayed as main sections
Because they're just links rather than embedded in the navbar structure, they can be less visible in some themes. Consider trying to get everything onto one line to comply with the Bootstrap structure.
Hi,
I'm Working on the OCS platform and i was wondering if i can use this bootstrap implementation to enhance the aparience of that platform.
The Documentation of the OCS is not good as the OJS doc.
Hi,
I really like to see bootstrap in OJS, so many thanks for your efforts!
However, I cloned the repo to the appropriate folder named bootstrap3 and could find the theme in the website settings dialogue. But once activated the page is "naked"... No css, etc.
Is there a brief summary of how to get going with the current state?
Best
Andreas
The extra bootstrap themes we chucked in last-minute need to be organised a bit better, and licensing needs to be checked for distribution purposes. Then more themes bundled.
They're loaded via a relative URL that doesn't work with our $$$call$$$
approach. Needs a novel solution.
Hi,
The editors of a journal I'm admin for wanted to include the author biography in article view. I made some simple changes to the theme: ubbdst/ojs@d6e2078 to accomodate this. Basically I just copied the corresponding section from the standard OJS template and changed some tags. Don't know how well my solution plays with the rest of the code, but it works for our particular journal and theme, perhaps there are other more appropriate tags (<h5>
is a bit arbitrary for instance) in some places.
We keep the theme directly in our OJS fork, and not as a submodule, for now, so can't do a pull request.
The accessible menu title should not be wrapped in a <h2>
:
https://github.com/NateWr/bootstrap3/blob/master/templates/frontend/components/header.tpl#L30
Google Scholar seems to be indexing that as the article title:
https://scholar.google.com/scholar?q=%22Quick+jump+to+page+content%22&btnG=&hl=en&as_sdt=0%2C5
Hi,
I am using ojs 3.1.1.0 in localhost xampp v3.2.2, when i click Archive in my website it directed to a blank page.
this is the error shown in error log
PHP Fatal error: Uncaught Error: Call to a member function getPageCount() on array in C:\xampp\htdocs\ojs\cache\t_compile\b1833e07cde48b95bfa6dfe66d9ad2430979a526^%%6B^6B5^6B5271FB%%issueArchive.tpl.php:6\nStack trace:\n#0 C:\xampp\htdocs\ojs\lib\pkp\lib\vendor\smarty\smarty\libs\Smarty.class.php(1257): include()\n#1 C:\xampp\htdocs\ojs\lib\pkp\classes\template\PKPTemplateManager.inc.php(797): Smarty->fetch('frontend/pages/...', NULL, 'b1833e07cde48b9...', true)\n#2 C:\xampp\htdocs\ojs\lib\pkp\lib\vendor\smarty\smarty\libs\Smarty.class.php(1107): PKPTemplateManager->fetch('frontend/pages/...', NULL, 'b1833e07cde48b9...', true)\n#3 C:\xampp\htdocs\ojs\lib\pkp\classes\template\PKPTemplateManager.inc.php(872): Smarty->display('frontend/pages/...', NULL, NULL)\n#4 C:\xampp\htdocs\ojs\pages\issue\IssueHandler.inc.php(152): PKPTemplateManager->display('frontend/pages/...')\n#5 C:\xampp\htdocs\ojs\lib\pkp\classes\core\PKPRouter.inc.php(372): IssueHandler->archive(Array, Object(Request))\n#6 C:\xampp\htdocs\ojs\lib\pkp\classes\core\PKPPageRo in C:\xampp\htdocs\ojs\cache\t_compile\b1833e07cde48b95bfa6dfe66d9ad2430979a526^%%6B^6B5^6B5271FB%%issueArchive.tpl.php on line 6, referer: http://localhost/OJS/index.php/art/index
Please help to solve this problem
Pagination (eg - issue archives) uses a custom template function, page_links
which calls smartyPageLinks
.
See if we can pull off Bootstrap-style pagination links with the function params.
When using Bootstrap 3 theme with current OJS master branch PDF viewer works incorrect and uses only half of screen height.
Browser console produce following warnings:
TypeError: options.container is null
http://127.0.0.1:8000/plugins/generic/pdfJsViewer/pdf.js/web/viewer.js
Line 3918
TypeError: canvas is null
http://127.0.0.1:8000/index.php/test/article/view/1/1
Line 52
Right now it's cats.
Also, if no article cover image exists it should fall back to the issue. And if neither exist maybe the layout should change.
@NateWr, per https://github.com/NateWr/bootstrap3/blob/master/BootstrapThreeThemePlugin.inc.php#L30 this plugin expects a styles/bootstrap3.less
to exist, but it doesn't -- there's a bootstrap.less
file instead. I think this is the cause of http://forum.pkp.sfu.ca/t/problem-with-css/31267.
The site that I support (https://revistas.reduc.edu.cu/), is a multisite that contains 7 journals and the main page (IndexSite) works with a template (that I modified) based on bootstrap3 of @NateWr. In a virtual test machine I tried to resize the blocks in the right sidebar, but when I try to modify bootstrap-rtl.min.css it seems to have no effect.
What I can do? Greetings Eduardo Osquel
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google ❤️ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.