pjkundert / python-slip39 Goto Github PK

4 groups is a sane default. Consider allowing as little as 2 groups in MacOS UI (group removal).

At the moment, the generated mnemonic cards contain lots of information: mnemonic words, group composition, group names, group thresholds, cryptocurrency names, cryptocurrency addresses, watermarks...

As a consequence, they look quite "crowded", and they feature some data that I don't want to disseminate with my mnemonic cards.

I would prefer these cards to be as simple, plain and "boring" as possible. This is a security feature. I don't want these cards to attract any unwanted curiosity or attention. I don't want them to leak more information or hints than necessary. I don't want them to have any reference to cryptocurrencies. And I certainly don't want them to give away the addresses of my wallet, or the cryptocurrencies I'm interested in.

On the cover page, it would be useful to have an indication of the group threshold, ie the number of groups that are required to recover the master secret.

This information is currently recorded on each mnemonic card, but I think it would make more sense to print it on the cover page itself.

The block of mnemonic cards seems to be in the upper left corner of the printable area. I think it would look better, and would be easier to print, if this block of cards was centered on the page.

The first three mnemonic words of each group act as an identifier of this group and don't contain any secret information.
It would be useful to record the first three words of each group on the cover page, in the recipient list, for example.

When running:

$ python3 -m slip39 -c BTC -w password --paper a4
...
2023-07-12 17:59:10 slip39           Failed to write PDFs: integer division or modulo by zero
Traceback (most recent call last):
  File ".../python-slip39/slip39/main.py", line 187, in main
    write_pdfs(
  File ".../python-slip39/slip39/layout/pdf.py", line 504, in write_pdfs
    p,(offsetx,offsety) = page_xy( wall_n )
                          ^^^^^^^^^^^^^^^^^
  File "/home/fdegros/experimental/python-slip39/slip39/layout/components.py", line 552, in page_xy
    page,nth            = divmod( num, comps_pp )
                ^^^^^^^^^^^^^^^^^^^^^^^
ZeroDivisionError: integer division or modulo by zero

I suspect this has something to do with the fact that the paper wallets are slightly too wide to fit on an A4 page.

Issue analogs to this one: BlockchainCommons/lethekit#38

I think it should be made more clear that there is an incompatibility between bip39 and slip39 standards.

This slip39 tool uses a derivation path starting with m/44' for both legacy and SegWit addresses, for both BTC and LTC. This is different from other major wallets, which use m/49' for SegWit addresses. Is this discrepancy an oversight, or a deliberate design decision?