pinnaculum / py-multiformats-cid

Self-describing content-addressed identifiers for distributed systems implementation in Python (fork of the deprecated ipld/py-cid)

I don't use this platform anymore (only keeping a few mirror repos around). All my opensource work is done on GitLab as @cipres.

py-multiformats-cid's Issues

pure python support for dag-cbor, dag-json or dag-pb codecs?

Thanks a lot for the great repo.

I'm looking for a pure python implementation of codecs dag-cbor, dag-json or dag-pb.

To my surprise, I don't find any. The closest I found is @odesenfans'https://github.com/aleph-im/py-ipfs-cid, which is great. However, it is not pure-python, it depends on Rust and a rust toolchain on the target machine.

Have you ever seen a pure python implementation of dag-json anywhere?

Thanks!

Wrong Encoded version of the raw representation of the CID object

• CID (Content IDentifier) version:
• Python version: 3.9
• Operating System: Debian

Description

I have implemented this function to return a CIDv1 object.

def encodeReference(ref: Union[str, Reference], codec: str, version: Optional[int] = 1) -> CIDv1:
    """
    create a new CID object by default and make it CIDv1.
    """
    hash_bytes = hexToBytes(ref)

    return CIDv1(codec, keccak(hash_bytes))

# use case
>>> test_reference = "ca6357a08e317d15ec560fef34e4c45f8f19f01c372aa70f1da72bfa7f1a4338"
>>> cid = swarm_cid.encodeReference(test_reference, "swarm-manifest" 1)
>>> str(cid)

What I Did

# Expected output
bah5acgzazjrvpieogf6rl3cwb7xtjzgel6hrt4a4g4vkody5u4v7u7y2im4a

# Got
bah5adiu4n2h72bxilg6iiqulrx2m3nuyzliwpyvhmidskdedbpevg54o

Add Types!

Mypy complains and I have to silence it like this (which is not ideal).

from multiformats_cid import from_bytes  # type: ignore

If the project is already typed, then it should be as easy as adding an empty file called py.typed to the base module.

and adding this to setup configuration:

[options.package_data]
cid = py.typed

It appears I posted the issue in the wrong place:

multiformats/cid#56

Missing py.typed file

py-multiformats-cid/setup.cfg

Line 39 in 333a516

cid = py.typed

Unfortunately, this file is still not being included in the published package. I think it needs to be changed to the root directory:

multiformats_cid = py.typed