pimcoumans / animationplanner Goto Github PK

Problem

Any animation containing multiple other animations aren’t passing the cancelling on to their sub-animations, only flat sequences are cancelled.

Proposed solution

Add func cancel() to Animatable (or a more appropriate protocol) so every animation can handle it for their specific case. Maybe create default implementation for Animation where it just immediately executes changes again, but making sure RunningSequence only calls this method when it’s the currently running animation. For years now (who new) UIView animations are ‘additive’, meaning they can’t be cancelled by performing the same changes as the animation. Either the currently running animations are played out and subsequent animations are cancelled, or a UIViewPropertyAnimators runs for each animations that can be cancelled.

As AnimationPlanners knows exactly how long animations take, a CADisplayLink can be created for its duration set with the max framerate. Animations can also have a property to manually enable this behavior.

Source:
https://github.com/duraidabdul/FrameRateRequest

Issue

When no actual value is changed in an animation, the delay leading up to that animation is ignored as well considering nothing actually needs to animate.

Proposed solution

1. Add test to confirm specific issue
2. Make sure actual animation has taken place (no good idea how yet), use DispatchQueue.asyncAfter() when delay needs to be manually added