v.7.0.0 about donald

[bddckr]

I've just did a similar change to a codebase at work myself! Turns out using type aliases like this, while saving a few characters to type, can easily confuse the dev working with it.

Without the aliases it's way easier to identify that the result Donald provides is a regular Result. Thus the user knows to not look for a DbResult module with the expected functions and instead can just use the Result module's functions.

Thumbs up from me as well!

[pblasucci]

These seem very reasonable to me. 👍

[bddckr]

IMO for dbResult and dbResultTask we can use any such builder other packages specifically offer. After all, this now is just a regular result and a regular task (with a specific value type).

dbCommand I've never personally used as I always found the pipe-able API way easier to use (and read in PR reviews).

[FoggyFinder]

Yes, it would be great to get rid of DbResult & DbResultTask types. Currently I have to map those into Result/Option every time. It's not very convenient indeed.

Btw, fluent syntax saved a lot of my time when I decided replace Fumble with Donald in one of my projects. Big thank you for such wonderful library that is getting better with each release.

[pimbrouwers]

Thanks Foggy! I agree that they are unnecessarily gratuitous (to borrow a phrase from Paul).

I'm so glad to hear that you're enjoying it. Very pleased with the evolution and this type of feedback is what keeps me motivated!

[pimbrouwers]

@bddckr @pblasucci

Any specific thoughts on the computation expressions? Including even the dbCommand { } which I regret in hindsight.

[pimbrouwers]

Thank you Christopher! I appreciate the feedback. My thoughts resemble your own, on all fronts.

[pblasucci]

👍 for dropping the aliases, and for dropping the associated computation expressions. I dislike libraries providing those sort of general-purpose cross-cutting utilities (unless that's the library's whole purpose... c.f. FSharp.Core).

But I'm on the fence about the computation expression for dbCommand. I find the aesthetic rather pleasant. That having been said, I don't think it's critical to the library. If dropping it quantifiably improves the maintenance burden, then you should do it. 🙂

[pimbrouwers]

Thanks so much Paul. I agree that the aliases and associated expressions are not great. Dropping them makes the library better for sure, at least in the sense of integrating into people's programs.

The dbCommand expression, I think you're right. It's nice syntax sugar and more importantly the original external form. I think preserving it will help ease the migration for some.