Something like «makemigrations» about piccolo

[dantownsend]

Ah, I see - sorry for the confusion.

We have the ability to run all migrations - this should work:

piccolo migrations forwards all

I just checked and it's not in the docs - we should mention it here.

There's no option currently to make migrations for all apps. We do what you suggest and have something like:

piccolo migrations new all --auto

[dantownsend]

@hoosnick Yeah, you're right - we just have to loop through all the apps.

I've opened a draft PR. It needs a few more tests, but hopefully that does the trick.

[dantownsend]

This is the Piccolo equivalent:

piccolo migrations new my_app --auto

As mentioned in the discussion, we should reorder the docs, so this appears nearer the top of the page, as we mention manual migrations first, which is a less common use case.

[hoosnick]

@dantownsend Yes I know this command, if I have a project with 7-8 apps to create automatic migration files for all apps at one? We need such a command, which itself creates migration files in the directories related to the changes in the tables in each app.

Here's how I see it:

piccolo migrations new all

Creating migrations for 'myapp-1':
    Created tables                        2
    Dropped tables                        0
    Renamed tables                        0
    Created table columns                 5
    Dropped columns                       0
    Columns added to existing tables      0
    Renamed columns                       0
    Altered columns                       0
Creating migrations for 'myapp-2':
    Created tables                        2
    Dropped tables                        0
    Renamed tables                        0
    Created table columns                 5
    Dropped columns                       0
    Columns added to existing tables      0
    Renamed columns                       0
    Altered columns                       0
Creating migrations for 'myapp-3':
    Created tables                        2
    Dropped tables                        0
    Renamed tables                        0
    Created table columns                 5
    Dropped columns                       0
    Columns added to existing tables      0
    Renamed columns                       0
    Altered columns                       0

piccolo migrations forwards all

                          SESSION_AUTH
----------------------------------------------------------------
👍 1 migration already complete
🏁 No migrations need to be run

                              USER
----------------------------------------------------------------
👍 3 migrations already complete
🏁 No migrations need to be run

                         PICCOLO_ADMIN
----------------------------------------------------------------
👍 0 migrations already complete
🏁 No migrations need to be run

                             myapp-1
----------------------------------------------------------------
👍 8 migrations already complete
⏩ 1 migration not yet run
🚀 Running 1 migration:
  - 2023-07-13T14:37:01:492084 [forwards]... running 2023-07-13T14:37:01:492084
ok! ✔️

                            myapp-2
----------------------------------------------------------------
👍 2 migrations already complete
⏩ 1 migration not yet run
🚀 Running 1 migration:
  - 2023-07-13T14:37:01:492084 [forwards]... running 2023-07-13T14:37:01:492084
ok! ✔️

                             myapp-3
----------------------------------------------------------------
👍 1 migration already complete
⏩ 1 migration not yet run
🚀 Running 1 migration:
  - 2023-07-13T14:37:01:492084 [forwards]... running 2023-07-13T14:37:01:492084
ok! ✔️

[hoosnick]

When do you plan to add it?

I think if the AppConfig list of apps is returned in the method below, it's enough to go through the for loop in the new command function in the migrations app.

piccolo/piccolo/conf/apps.py

Lines 460 to 469 in 97292cc

	def get_app_config(self, app_name: str) -> AppConfig:
	"""
	Returns an ``AppConfig`` for the given app name.
	"""
	modules = self.get_app_modules()
	for module in modules:
	app_config = module.APP_CONFIG
	if app_config.app_name == app_name:
	return app_config
	raise ValueError(f"No app found with name {app_name}")

piccolo/piccolo/apps/migrations/commands/new.py

Lines 210 to 249 in 97292cc

	async def new(
	app_name: str,
	auto: bool = False,
	desc: str = "",
	auto_input: t.Optional[str] = None,
	):
	"""
	Creates a new migration file in the migrations folder.
	:param app_name:
	The app to create a migration for.
	:param auto:
	Auto create the migration contents.
	:param desc:
	A description of what the migration does, for example --desc='adding
	name column'.
	:param auto_input:
	If provided, all prompts for user input will automatically have this
	entered. For example, --auto_input='y'.
	"""
	print("Creating new migration ...")
	engine = Finder().get_engine()
	if auto and isinstance(engine, SQLiteEngine):
	sys.exit("Auto migrations aren't currently supported by SQLite.")
	app_config = Finder().get_app_config(app_name=app_name)
	_create_migrations_folder(app_config.migrations_folder_path)
	try:
	await _create_new_migration(
	app_config=app_config,
	auto=auto,
	description=desc,
	auto_input=auto_input,
	)
	except NoChanges:
	print("No changes detected - exiting.")
	sys.exit(0)