Coder Social home page Coder Social logo

`Ruff` as a linter for Piccolo about piccolo HOT 3 CLOSED

sinisaos avatar sinisaos commented on August 28, 2024
`Ruff` as a linter for Piccolo

from piccolo.

Comments (3)

dantownsend avatar dantownsend commented on August 28, 2024

Yeah, I've seen that is has become very popular.

My understanding is it's a replacement for flake8. I've never really had issues with the performance of flake8 - even though Piccolo is a pretty big project, I think the performance difference is probably more apparent when there's 100,000's or millions of lines of code.

from piccolo.

dantownsend avatar dantownsend commented on August 28, 2024

I'm not sure if it gives a better developer experience in VSCode. I know VSCode is power hungry on my laptop, partially due to the all of the linters etc being run.

from piccolo.

sinisaos avatar sinisaos commented on August 28, 2024

I don't know about VS Code, I ran it from the terminal with ./scripts/lint.sh and Ruff executes in no time. Ruff also found a couple of E721 Do not compare types, use isinstance() like here https://github.com/piccolo-orm/piccolo/blob/83ea66323ef5a8e4010ea3ee19f34163bc881ace/piccolo/query/mixins.py#L114C9-L114C39
which should be if not isinstance(self.interval, str):, but we can fix it without Ruff.
This was just an idea and if you think there won't be any special benefits, I'll close this issue.

from piccolo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.