composer.json version requirement for nikic/php-parser possibly too restrictive about phpstan-symfony

[ondrejmirtes]

Hi, this is not possible, the new PHP parser is quite different and it's not possible to support old and new version at the same time.

[ondrejmirtes]

Your solution is to install PHPStan separately with a different composer.json (in a subdirectory perhaps) or use something like Docker for this (https://github.com/phpstan/docker-image).

[d42ohpaz]

@ondrejmirtes you misunderstand, I am by far not asking for support of ^1.0. Please re-read this key statement:

My suggestion, as a library, would be to use a less restrictive version constraint of >=4.0 so that your library can still take advantage of the minimum requirements while not conflicting with newer packages/libraries depending on newer versions.

[ondrejmirtes]

I don't see how having "nikic/php-parser": ">=4.0" instead of "nikic/php-parser": "^4.0" would help?

[d42ohpaz]

@ondrejmirtes if package/xyz requires nikic/php-parser: "^5.0", then I would not be able to use phpstan/phpstan-symfony because this package's constraint says it's restricted to just the 4.0 branch. If, however, this package said >=4.0, then everybody would be happy.

[ondrejmirtes]

It would be too dangerous to proclaim support for php-parser 5.x when there will be BC breaks and work involved to really support it. 😊

[d42ohpaz]

@ondrejmirtes Thank you for the pointer about different directories; it caused me to stumble on support for environment variables by composer, which let's me hack around this ugly limitation.

I will leave you with this plea: please strongly consider opening up version constraints (as much as future versions will allow you, re: backward-compatibility). Short-sightedness leads to doors being slammed in developer's faces.

Thank you! :)

[ondrejmirtes]

I have to always consider the maintenance burden when opening up the constraints but maybe the next major PHP-Parser version won't contain as many changes 😊 After all, I supported 2.x alongside 3.x for a long time 😊

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.