Comments (5)
Hi, this is not a bug. Your method should be declared such as:
protected function supports(string $attribute, mixed $subject): bool
Same as the parent. If you widen the type by omitting the parameter type on purpose, you should say in the PHPDoc what the type is supposed to be, such as @param mixed $attribute
.
from phpstan-symfony.
@ondrejmirtes Symfony 4.4 doesn't have native types set, thus I also can't use native type in supports
(because of the signature mismatch). But what symfony does have is the @param string $attribute
set, which is ignored in the supports
method, but is not ignored in the voteOnAttribute
method (probably because of asserts in the stub).
But maybe I misinterpret the situation and with treatPhpDocTypesAsCertain: false
it's required to add @param string $attribute
to the supports
method in a custom Voter
. Though it seems a little bit redundant, as annotation was already added by the third-party vendor.
from phpstan-symfony.
@luxemate You've left out the information about Symfony 4.4 in your issue. I'd accept a PR that adds @param string $attribute
into the stub.
from phpstan-symfony.
@ondrejmirtes I've created a new PR and added only @param string $attribute
as you've suggested.
from phpstan-symfony.
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
from phpstan-symfony.
Related Issues (20)
- Missing array as an available return type for InputBag::get() HOT 2
- Detection of invalid route names (and perhaps even missing/invalid params)
- `Required` attribute should remove readonly properties errors HOT 8
- Template type TData on class Symfony\Component\Form\FormInterface is not covariant HOT 1
- The constant_hassers not working as constantHassers default of extension.neon always used
- Support Symfony Validator HOT 6
- Narrow property types in validated objects HOT 2
- Take into account the dynamic Kernel class HOT 16
- Request::getContent() return value without asResource is not always a string HOT 2
- Form "has invalid type Symfony\Component\Form\TData" after patch upgrade
- [Feature Request] Enforce `ResetInterface` on non-read-only services HOT 2
- PHPstan does not find container helper functions used on packages php configs HOT 5
- Remove reporting of deprecated method calls in tests flagged as `@group legacy` HOT 4
- Rule Idea: UriSigner check result is used and not used as a void method HOT 2
- Class or interface 'PHPStan\Symfony\ServiceMapFactory' not found. HOT 2
- wrong asumption about `InputInterface::getArgument()` return type in `interact()` HOT 5
- Type inference for HeaderBag could support has()
- Type refinement for options in form types HOT 1
- Service fetched by interface has type of its concrete implementation alias, which is against LSP HOT 12
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from phpstan-symfony.