Comments (7)
Hello @klipach,
I agree we should use the LTS version as the minimum version for Symfony.
Symfony ^2.3 seems the way to go for GrumPHP.
The solution requires some extra testing on all platforms to make sure everything is still working!
from grumphp.
The composer.json is changed on the master branch so that you can use Symfony 2.3.
Commit: d12b1d6
The package we use for git actions, requires symfony process 2.4.
This results in an unresolvable error:
Your requirements could not be resolved to an installable set of packages.
I created a ticket on the official repository:
gitonomy/gitlib#85
When this ticket is resolved, I will be testing with Symfony 2.3 on Linux and Windows.
from grumphp.
Yesterday i checked the same solution locally, i had a problem with dependency injection https://github.com/phpro/grumphp/blob/master/resources/config/services.yml#L42 there is no support for expression engine for DI 2.3 https://github.com/symfony/DependencyInjection/blob/2.3/composer.json
from grumphp.
This means that the lowest we can currently go without modifying the code is Symfony 2.4.
I will still need to test with version 2.4 to make sure all features will work.
from grumphp.
it is no so easy to downgrade to fit Symfony LTS version. I think you can close this ticket.
from grumphp.
LTS is probably not possible. But we will aim to make the Symfony version as low as possible.
V2.4 might work. I will keep this ticket open until we tested with some projects.
from grumphp.
It seems to work with Symfony 2.4. So that will be our minimum dependency.
from grumphp.
Related Issues (20)
- With GrumPHP php-cs-fixer is not able to exclude the directories as configured in .php-cs-fixer.php HOT 3
- Custom task not working when parallel option is enabled HOT 5
- Add support for PSR-4/`composer dump-autoload` testing HOT 3
- Consider adding a `composer.lock` file in the repository HOT 14
- phpcs does not detect default ruleset xml file HOT 6
- PHPMD task does not check all file extensions HOT 5
- Don't do commit message checks on merges? HOT 8
- Memory is not being released in parallel execution HOT 2
- Grumphp running without `.git` folder? HOT 4
- Print the commit message when failing on `git_commit_message` HOT 4
- how can I use grum with docker-compose ? HOT 3
- Fails to Recognize PHPStan Baseline During Commit Workflow
- Override open_basedir only for grumphp test HOT 2
- Grumphp config using default PHPCS XML and other standard's sniff HOT 2
- Undefined constant PhpParser\ParserFactory::PREFER_PHP7 when using `nikic/php-parser` version 5. HOT 1
- Support multiple php versions for tasks HOT 2
- [Task] Add bin/console task for Symfony HOT 1
- husky/lint-staged compatibility HOT 5
- The application requires the version "^7.2" or greater. HOT 2
- Support for multiple PHPStan tasks HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from grumphp.