Comments (5)
This seems to be specific to certain file extensions - .inc is checked as expected, but .module
and .install
are not
from grumphp.
The phpmd task currently has no support for the --suffixes
flag.
It shouldn't be too hard to add it.
Care to give it a spin?
https://github.com/phpro/grumphp/blob/v2.x/src/Task/PhpMd.php
from grumphp.
As far as I can see, the changes in https://github.com/phpro/grumphp/compare/v2.x...malcomio:grumphp:extensions?expand=1 should work, but the other file types are still not being checked
debugging inside \GrumPHP\Process\ProcessBuilder::buildProcess
, I can see the arguments being set as I'd expect:
[commandline:Symfony\Component\Process\Process:private] => Array
(
[0] => /Users/mayoung/Code/grumphp-test/vendor/bin/phpmd
[1] => docroot/test.inc,docroot/test.install,docroot/test.module,docroot/test.php
[2] => ansi
[3] => phpmd.xml
[4] => --suffixes 'php,module,inc,install,test,profile,theme'
)
I must be missing something...
from grumphp.
The process building handles escaping for you per argument. You don't need to add quotes yourself.
You probably need to make sure that --suffixes and the list of extensions are 2 separate arguments? (I don't use that tool, so you might need to consult the docs of phpmd on how to use that flag)
from grumphp.
Thanks - they did indeed need to be separate arguments
I've created #1103 with these changes
relevant PHPMD docs are at https://phpmd.org/documentation/index.html
--suffixes - Comma-separated string of valid source code filename extensions, e.g. php, phtml.
from grumphp.
Related Issues (20)
- Auto prepending commit message with JIRA ticket number HOT 4
- With GrumPHP php-cs-fixer is not able to exclude the directories as configured in .php-cs-fixer.php HOT 3
- Custom task not working when parallel option is enabled HOT 5
- Add support for PSR-4/`composer dump-autoload` testing HOT 3
- Consider adding a `composer.lock` file in the repository HOT 14
- phpcs does not detect default ruleset xml file HOT 6
- Don't do commit message checks on merges? HOT 8
- Memory is not being released in parallel execution HOT 2
- Grumphp running without `.git` folder? HOT 4
- Print the commit message when failing on `git_commit_message` HOT 4
- how can I use grum with docker-compose ? HOT 3
- Fails to Recognize PHPStan Baseline During Commit Workflow
- Override open_basedir only for grumphp test HOT 2
- Grumphp config using default PHPCS XML and other standard's sniff HOT 2
- Undefined constant PhpParser\ParserFactory::PREFER_PHP7 when using `nikic/php-parser` version 5. HOT 1
- Support multiple php versions for tasks HOT 2
- [Task] Add bin/console task for Symfony HOT 1
- husky/lint-staged compatibility HOT 5
- The application requires the version "^7.2" or greater. HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from grumphp.