Auto prepending commit message with JIRA ticket number about grumphp

[veewee]

hmm interesting...
Wouldn't it be easier to check with regex that something needs to go after that?
Like: /ABC-[0-9]+ : (.+)/?

[veewee]

I'm a bit confused by this:

• prepare-commit-msg: prepends jira issue number to the commit message file
• commit-msg runs on the changed commit file

The (grumphp) commit-msg hook triggers the git_commit_message task, meaning you can validate the outcome AFTER saving the file in there.

So by changing the regex /ABC-[0-9]+ : (.+)/ it won't let your commit pass if you don't enter a message after the jira issue number as you expect right? (given the fact it requires a non empty (.+). You could change this to (.{5,}) to specify a minimum or you could force it to contain non-space characters.

[delboy1978uk]

@veewee thanks for the speedy reply! yes that was my idea, as far as i understand however, the prepare-commit-msg hook above runs before the editor opens and we enter our commit message, the check would have to happen after we save and exit the editor, and so I guess that would be the commit-msg hook, but that's when I noticed that GrumPHP is using that hook. So I'm looking for a way to do that check with GrumPHP if possible

[delboy1978uk]

Aha! That's exactly what I needed, I didn't know abut that task! So I can keep my prepend hook and do the commit check from using GrumPHP now. Fantastic! Thanks for your help @veewee