Comments (4)
hmm interesting...
Wouldn't it be easier to check with regex that something needs to go after that?
Like: /ABC-[0-9]+ : (.+)/
?
from grumphp.
I'm a bit confused by this:
- prepare-commit-msg: prepends jira issue number to the commit message file
- commit-msg runs on the changed commit file
The (grumphp) commit-msg hook triggers the git_commit_message task, meaning you can validate the outcome AFTER saving the file in there.
So by changing the regex /ABC-[0-9]+ : (.+)/
it won't let your commit pass if you don't enter a message after the jira issue number as you expect right? (given the fact it requires a non empty (.+)
. You could change this to (.{5,})
to specify a minimum or you could force it to contain non-space characters.
from grumphp.
@veewee thanks for the speedy reply! yes that was my idea, as far as i understand however, the prepare-commit-msg
hook above runs before the editor opens and we enter our commit message, the check would have to happen after we save and exit the editor, and so I guess that would be the commit-msg
hook, but that's when I noticed that GrumPHP is using that hook. So I'm looking for a way to do that check with GrumPHP if possible
from grumphp.
Aha! That's exactly what I needed, I didn't know abut that task! So I can keep my prepend hook and do the commit check from using GrumPHP now. Fantastic! Thanks for your help @veewee
from grumphp.
Related Issues (20)
- Don't do commit message checks on merges? HOT 8
- Memory is not being released in parallel execution HOT 8
- Grumphp running without `.git` folder? HOT 4
- Print the commit message when failing on `git_commit_message` HOT 4
- how can I use grum with docker-compose ? HOT 3
- Fails to Recognize PHPStan Baseline During Commit Workflow
- Override open_basedir only for grumphp test HOT 2
- Grumphp config using default PHPCS XML and other standard's sniff HOT 2
- Undefined constant PhpParser\ParserFactory::PREFER_PHP7 when using `nikic/php-parser` version 5. HOT 1
- Support multiple php versions for tasks HOT 2
- [Task] Add bin/console task for Symfony HOT 1
- husky/lint-staged compatibility HOT 5
- The application requires the version "^7.2" or greater. HOT 2
- Support for multiple PHPStan tasks HOT 2
- How do you think about a configuration to opt-in to continue the commit if fixer could fix everything automatically? HOT 2
- DistFileLoader doesn't import another file
- Add support for git_pre_push HOT 1
- git_blacklist never runs? HOT 5
- Composer validate task not running when composer.lock changes
- Env variables don't get expanded in task definitions
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from grumphp.