phpbenchmarks / benchmark-kit Goto Github PK

Hello phpbenchmarks! I'm hailing from CodeIgniter 4. Frequently we will have PRs come up (like this and this) that the code will all seem fine but there are larger questions of performance. That got me thinking how I would evaluate a PR to answer the question: "Will this change significantly impact the framework's performance?"

My solution: a GitHub Action that returns a relative benchmark result similar to Code Coverage that could be assessed for "pass" or "failure". I've poked around at benchmarking and found you all, ready to go with your benchmark kit.

My question: Has anyone tried wrapping this kit in a GitHub Action? Would you be willing to work with us on launching a CodeIgniter 4 kit?

Hello !

When using the command phpbenchmark nginx:vhost:statistics:create X.X an error is thrown because the script try to right the template for statistics in the /var/benchmark-kit/public directory of the container.
This folder is owned by root:root with default file permission so the current user (phpbenchmarks) can't write the file.

Why when building the container, don't you give ownership of the public folder to "phpbenchmarks" (as you do for the entrypoint file) ?

Or you could set this public folder as chmod 777 like nginx and the var folder.
As you commented in the dockerfile, there is no security concern in this app so lot's of solution here ^^

I can do a PR with your preferred solution if you want / need !

Using vscale Ubuntu 20.04 64bit 512 МБ RAM 20 ГБ SSD 1 CPU

Vhosts are configured from a template from benchmark kit, but they should be created from the template configured in benchmark code.

Hey there, can we add Unic framework benchmark results.

This command call BenchmarkValidateStatisticsCommand then save last statistics: in other word, only PHP 7.4 statistics are saved.

For PHP benchmarks, it's not a problem because there is only the current benchmarked PHP version configured.

But for all other components, PHP 7.4 statistics will be saved for all PHP versions.

ValidateBenchmarkStastisticsCommand is the only one to extends AbstractValidateBenchmarkCommand, remove this abstract class.

Create this command to output HTML returned by phpinfo.benchmark-kit.loc.

As PHP 7.4 preload can sometimes cause PHP-FPM to fail when restart, and sometimes not fail : try to restart it 5 times before stopping the execution.

Add path to preload.php in error message.

This data comes from Benchmark::getBenchmarkType() but that's not the right one.

We should remove id and use slug.

Take care to public static function getSourceCodeUrlIds(string $type = null, int $componentType = null): array: componentType will be a slug.

The kit in the readme is not found

https://raw.githubusercontent.com/phpbenchmarks/benchmark-kit/4.0.0/phpbenchkit.sh
also, this tag is not there, same happens for other tags

Would I use this repo to add a new serializer benchmark?

Id to transform into slug:

• component id
• benchmark type id

Used in:

• export:benchmark:configuration

Hi,

just checking if there is a reason why codeigniter4 is not in the benchmarks.

Create this command to validate phpinfo vhost HTTP code is 200.

Used into:

• export:benchmark:configuration

Add this command to validate that preload.php exists only for PHP compatibles versions.

TodoExecuteCommand save statistics only for the default BenchmarkConfiguration.

Remove this test and save statistics for all BenchmarkConfiguration.

Renamme all --no-foo options to --foo=[true|false]

As PHP 7.4 preload can sometimes cause PHP-FPM to fail when restart, and sometimes not fail : try to retrieve statistics 5 times instead of 1, with a restart of PHP FPM each time.

get_declared_classes() and get_declared_traits() could cause a 502, and restart PHP-FPM without doing anything else can randomly solve the problem.

Command name are camelCase, rename them to slug.