phpbb-extensions / cannedmessages Goto Github PK

Whenever a message is updated its order is being set to the highest number and moved to the bottom of the list. Should preserve whatever order it's been set at previously.

Only moving uses AJAX. Other functions like Deleting could use AJAX too.

Also should fix non ajax interactions, for example, when deleting but then aborting the confirm box by clicking no, the resulting page is an empty list, not a proper list or the list you were viewing previously.

Also some of the URL's look a bit weird. After deleting (clicking no) there's leftover parameters that shouldn't be there.

Basically the MCP controller needs a bit of retooling.

Add unit and functional tests

Code could be simplified quite a bit possibly if we use the nested set/tree class for all canned message data retrieval and storage, instead of the current "manual" implementation.