php-http / laravel-httplug Goto Github PK

Shouldn't we use a laravel related namespace. Eg. the bundle has Http\HttplugBundle. Isn't there such naming rules in laravel. My fear is that Http\Httplug is to generic.

The commit fae3d1b removed php-http/client-implementation. Why did we want to do that?

The php-http/client-implementation is a virtual package that makes sure we have at least one HTTPlug client. It makes sense to have it since a client is required for this library to be useful.

Read more about it here: http://docs.php-http.org/en/latest/httplug/users.html#details

As far as I know the generic recommendation is not to install these tools as packages, but use a phar version instead. The Styleci Bridge is okay, in fact, I am thinking about adding it as a dependency to boilerplate too as it works well with the PHAR.

I believe it is important that everybody, including us maintainers, is using PRs when making changes to a repository. When we use PRs everybody gets notified about the change. Minor changes could of course be merged directly, but we should always use PRs.

The package adds a binding for Http\Httplug\HttplugManager::class (and the alias 'httplug'). But when using dependency injection, I would much prefer to request Http\Client\HttpClient rather than Http\Httplug\HttplugManager.

Do you think it would be a good idea to add bindigs for Http\Client\HttpClient (and perhaps also Http\Client\HttpAsyncClient)?