phollyer / elm-phoenix-websocket Goto Github PK

When pushing with a payload of Json.Encode.null PhoenixJS errors with TypeError: Cannot read property 'constructor' of null

Expected:

• When a push times-out with a retry strategy other than Drop, it should by queued, counted down and re-sent.

Actual:

• There is no countdown and it isn't re-sent

This is only in the current unpublished build, and was introduced while refactoring.

If a channel topic is not joined and the leave function is called for the un-joined topic, the result is a JS Uncaught TypeError.

It should really be the responsibility of the user of the package to determine/monitor if a channel is joined prior to calling leave, but a safety net on the JS side wouldn't hurt.

👋 Hi! I was going through the code, and I realized there is an invalid source path in the examples elm.json file, pointing to ../../../src:

https://github.com/phollyer/elm-phoenix-websocket/blob/master/example/assets/elm/elm.json#L5

Hi! First of all, thanks for such a great package and example. I've been looking for something similar for quite a time.

I want to use it in a project that I'm working on; however, the docs in master refer to a v3.0.0, https://github.com/phollyer/elm-phoenix-websocket/tree/master/js#an-elm-spa, which seems to have not been published yet. Moreover, all the links in the example point to an unexisting Phoenix module in the Elm docs, like https://package.elm-lang.org/packages/phollyer/elm-phoenix-websocket/latest/Phoenix#socketState. Is this right, or am I missing anything?

The current round of refactoring introduced a bug causing pushes to not be sent automatically after the channel is joined.

This is only in the current unpublished build, and needs to be fixed prior to publishing 3.0.2.

pushWaiting should report pushes that are queued, in flight and timed out waiting to be re-tried.

Phoenix.disconnect leaves the internal model thinking it is still connected to channels so prevents re-connecting, and related query functions report inaccurate information.

The internal model is reset but the message to disconnect doesn't reach the JS.