phlow / simplicity Goto Github PK

I noticed, that tables are not rendered satisfactorily.

And found a simple solution. Suggesting to include it either into the code or as customizing option to the documentation

There is a table-scss Github project.
https://github.com/jwebcat/tables-sass

1. copy the _tables.scss file from the scss directory of that project to the sass/05_layout directory of simplicity.
2. add :@import "tables" to sass/00_layout.scss (@ row 27)
3. change the table section ofsass /04_typography/_general_typography.scss to

/* Tables
------------------------------------------------------------------- */
table{
        @extend %table;
/*      @extend %table-bordered;  */
        @extend %table-condensed;
  font-family: $font-family-sans-serif;
  font-size: .75em;}
 /*  stripes */
table   tr:nth-of-type(even) {
    background: rgba(0,0,0,.2)
}
td {
  vertical-align: top;
}

That fits beautiful into the theme and to it philosophy as well.

More like a question than an issue.

Not quite sure why there's a differentiation of line item <li> of the if forloop.last affecting the subheading of a post (around line 24 of _layouts/archive.html).

Shouldn't it simply be
`

{% for post in site.posts %}

• {% if post.subheadline %}{{ post.subheadline }}{% endif %}{{ post.title }}

{% endif %}
{% endfor %}

I adjusted mine and it seems to behave correctly, unless I'm wrong...
https://github.com/dwlfrth/dwlfrth.github.io/blob/master/_layouts/archive.html#L31

When I type

Type bundle exec jekyll serve --config _config.yml,_config_dev.yml

I get:

        Error: could not read file /Users/gpaulissen/Documents/GitHub/simplicity-gh-pages/vendor/bundle/gems/jekyll-3.8.5/lib/site_template/_posts/0000-00-00-welcome-to-jekyll.markdown.erb: Invalid date '<%= Time.now.strftime('%Y-%m-%d %H:%M:%S %z') %>': Document 'vendor/bundle/gems/jekyll-3.8.5/lib/site_template/_posts/0000-00-00-welcome-to-jekyll.markdown.erb' does not have a valid date in the YAML front matter.
         ERROR: YOUR SITE COULD NOT BE BUILT:
                ------------------------------------
                Invalid date '<%= Time.now.strftime('%Y-%m-%d %H:%M:%S %z') %>': Document 'vendor/bundle/gems/jekyll-3.8.5/lib/site_template/_posts/0000-00-00-welcome-to-jekyll.markdown.erb' does not have a valid date in the YAML front matter.

The solutions is to add the vendor directory to the exclude tag in _config.yml:

exclude:
- .sass-cache
- Gemfile
- Gemfile.lock
- README.md
- INSTALL.md
- vendor

Links are broken in the navigation page

I checked site.url, site.baseurl from here.
Based on the links in the navigation page and the conditions here I am not sure how it is broken.

jekyll build or jekyll serve generates a cache directory - .jekyll-cache

This directory is being shown as an untracked directory. We shall gitignore this directory.

The user @carlsonsantana validate your site template "https://phlow.github.io/simplicity" and found these accessibility errors:

• Page https://phlow.github.io/simplicity/:
  • Issue c05436b0-ee54-4755-a565-a019bdb7439f:
    • Type: Error
    • Code: WCAG2AA.Principle1.Guideline1_4.1_4_3.G18.Fail
    • Message: This element has insufficient contrast at this conformance level. Expected a contrast ratio of at least 4.5:1, but text in this element has a contrast ratio of 1.26:1. Recommendation: change text colour to #767676.
    • Selector: #tnav-menu > a
    • Context: <a href="#">Navigation</a>
  • Issue c4737a15-a347-4ea0-b14b-a2273c65a460:
    • Type: Error
    • Code: WCAG2AA.Principle4.Guideline4_1.4_1_2.H91.A.NoContent
    • Message: Anchor element found with a valid href attribute, but no link content has been supplied.
    • Selector: #tnav-share > a
    • Context: <a href="#"><svg class="nav-icon" viewBox="...</a>
  • Issue 62f478dd-a14c-4d81-b988-6a01a9d26c53:
    • Type: Error
    • Code: WCAG2AA.Principle4.Guideline4_1.4_1_2.H91.A.NoContent
    • Message: Anchor element found with a valid href attribute, but no link content has been supplied.
    • Selector: #tnav-search > a
    • Context: <a href="https://phlow.github.io/simplicity/search/"><svg class="nav-icon" viewBox="...</a>

You can check these accessibility errors using pa11y.
You can view the full validation results in our website.

Let us say that there are 10 articles in total.

I feel that it is better if we hide "Show All Articles", if all the 10 articles end up getting displayed in the first page itself (when posts_with_teaser_limit: 1 and posts_list_limit: 15 - upto 16 can be displayed in first page).

Let me know what you think. I have a fix ready; I can submit a Pull request.

Hi Moritz.

Probably just a Jekyll n00b question, but can you explain how the font: import: command works in the config.yml file?
I've attempted adding 3 new google fonts to the theme using the syntax as supplied in config.yml (ie font: import: 'name: weight...')
I get the feeling from elsewhere online that I need to either upload the font files to the assets directory or at least directly call the google source url. However your theme assets directory doesn't already contain the OOTB font files (Roboto, Fira Sans etc), and I can't find an scss file that references any font source urls. So I can't see a relevant pattern that should be followed for this theme.

My additions to the config.yml are:
font:
import: 'Averia+Libre:400,700' // font-family-serif
import: 'Expletus+Sans:400,400italic,500,500italic,600,600italic,700,700italic' // header-font-family
import: 'Open+Sans:400,400italic,600,600italic,700,700italic' // base-font-family

Many thanks,
Jess

Looks awesome on local server but after pushing to github and building on netlify the site looks like sass is striped. Any ideas?

I'd like to use simplicity as a git subrepo. It would be nice if you could provide a branch (master?) without _posts and _images, so it's easier to handle and update.

The installation would become even easier by dropping the step:

Delete all files in _posts/ and images/.