philonous / d-bus Goto Github PK

View Code? Open in Web Editor NEW

9.0 9.0 14.0 224 KB

strongly typed dbus client library

License: MIT License

Haskell 99.59% C 0.41%

d-bus's People

Contributors

Stargazers

Watchers

Forkers

teh rjmk jkarni silky edwardgeorge pbogdan afcady acarrico jforberg avnik frasertweedale roosemberth andreabedini mpardalos

d-bus's Issues

0.1.3.4 doesn't build on GHC 7.8

Preprocessing executable 'dbus-introspect' for d-bus-0.1.3.4...
[1 of 1] Compiling Main             ( dbus-introspect/Main.hs, dist/dist-sandbox-6b08ff11/build/dbus-introspect/dbus-introspect-tmp/Main.o )

dbus-introspect/Main.hs:23:31: Not in scope: ‘<$>’
cabal: Error: some packages failed to install:
d-bus-0.1.3.4 failed during the building phase. The exception was:
ExitFailure 1

Does mkProperty really emit propertyChanged?

The documentation for mkProperty states:

Create a property from a getter and a setter. It will emit a PropertyChanged signal when the setter is called. To
change this behaviour modify the propertyEmitsChangedSignal field

But the code doesn't seem to call propertyChanged or otherwise emit the signal (and as far as I can tell from my application, indeed this isn't emitted).

This affects mkTVarProperty too, which uses mkProperty.

Cabal version not matching the version on Hackage

Hackage has version 0.1.3.4, while the version in the Cabal file is 0.1.3.3.

Enable -Wall and clean warnings

Prevents problems like in #13

Make sure all functions that take a connection prevent it from being GCd

dbus-introspect directory missing

The Cabal file references a dbus-introspect executable in a directory with the same name. However, that directory doesn't exist in HEAD on master.

Documentation problem on Hackage

The documentation fails to build for the latest version on Hackage.

https://hackage.haskell.org/package/d-bus-0.1.3.4/reports/1

0.1.7 building error on ghc 8.2.2

Preprocessing library d-bus-0.1.7...
[ 1 of 18] Compiling DBus.Auth        ( src/DBus/Auth.hs, dist/build/DBus/Auth.o )
[ 2 of 18] Compiling DBus.Types       ( src/DBus/Types.hs, dist/build/DBus/Types.o )
[ 3 of 18] Compiling DBus.TH          ( src/DBus/TH.hs, dist/build/DBus/TH.o )
[ 4 of 18] Compiling DBus.Signature   ( src/DBus/Signature.hs, dist/build/DBus/Signature.o )
[ 5 of 18] Compiling DBus.Representable ( src/DBus/Representable.hs, dist/build/DBus/Representable.o )
[ 6 of 18] Compiling DBus.Method      ( src/DBus/Method.hs, dist/build/DBus/Method.o )

src/DBus/Method.hs:30:10: error:
    • Type indexes must match class instance head
      Expected: ArgTypes (IO (DBusArguments t))
        Actual: ArgTypes (IO (DBusArguments ts))
    • In the type instance declaration for ‘ArgTypes’
      In the instance declaration for ‘IsMethod (IO (DBusArguments t))’
   |
30 |     type ArgTypes (IO (DBusArguments ts)) = '[]
   |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

src/DBus/Method.hs:31:10: error:
    • Type indexes must match class instance head
      Expected: ResultType (IO (DBusArguments t))
        Actual: ResultType (IO (DBusArguments ts))
    • In the type instance declaration for ‘ResultType’
      In the instance declaration for ‘IsMethod (IO (DBusArguments t))’
   |
31 |     type ResultType (IO (DBusArguments ts)) = ts
   |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

src/DBus/Method.hs:35:10: error:
    • Type indexes must match class instance head
      Expected: ArgTypes (MethodHandlerT IO (DBusArguments t))
        Actual: ArgTypes (MethodHandlerT IO (DBusArguments ts))
    • In the type instance declaration for ‘ArgTypes’
      In the instance declaration for
        ‘IsMethod (MethodHandlerT IO (DBusArguments t))’
   |
35 |     type ArgTypes (MethodHandlerT IO (DBusArguments ts)) = '[]
   |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

src/DBus/Method.hs:36:10: error:
    • Type indexes must match class instance head
      Expected: ResultType (MethodHandlerT IO (DBusArguments t))
        Actual: ResultType (MethodHandlerT IO (DBusArguments ts))
    • In the type instance declaration for ‘ResultType’
      In the instance declaration for
        ‘IsMethod (MethodHandlerT IO (DBusArguments t))’
   |
36 |     type ResultType (MethodHandlerT IO (DBusArguments ts)) = ts
   |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
cabal: Leaving directory '/tmp/cabal-tmp-16539/d-bus-0.1.7'
Failed to install d-bus-0.1.7

Add Explicit closeConnection Method To API

Current API does not have an explicit close for a DBusConnection.

Closing a DBusConnection should gracefully end all signal and property change registrations / handlers as well as the cleanup of internal resources.

Handle extended introspection

The introspection format we support is very strict. We should allow additional elements and attributes.

Missing stackage release

The last 5 commits with fixes required on recent versions of GHC have not been released on hackage. I think a new release should be uploaded.

Maybe it would be convenient to wait until #23 has been merged to avoid the need of an extra release after such PR has been merged.

Don't allow empty object path in method call

The server will close the connection, leading to unexpected errors.