philipptrenz / covidpass.eu Goto Github PK

Ran into several cases where people had problem scanning the code on my iPhone 11. Compared with the QR code on third party apps, the Wallet one is less then half the size.

I am happy to help if you give me a pointer to where to start.

Even though sending the whole QR code to the server which contains sensitive personal data is not the best idea, you should definitely not log this data on your server.

https://github.com/philipptrenz/covidpass/blob/6dbffaf1b517f22429c5a9952638bd8f7b4714ed/server-middleware/rest.js#L57

https://github.com/philipptrenz/covidpass/blob/6dbffaf1b517f22429c5a9952638bd8f7b4714ed/server-middleware/rest.js#L66

If you log errors you should exclude everything that is related to the user or considered sensitive data

improve instructions for iOS users, that Safari shall be used for scanning QR-code.
using Chrome does not let the integration happen between Wallet => pass will not be installed there.

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: [e.g. iOS]
• Browser [e.g. chrome, safari]
• Version [e.g. 22]

Smartphone (please complete the following information):

• Device: [e.g. iPhone6]
• OS: [e.g. iOS8.1]
• Browser [e.g. stock browser, safari]
• Version [e.g. 22]

Additional context
Add any other context about the problem here.

@KhaosT introduced a PR at https://github.com/covidpass-org/covidpass to generate the pkpass fully locally within the client and only send the hashed data to the backend for signing. We should adopt that asap.

Hello I have used your website to add my covid cert to apple walet. I’m using iphone11 and certificate is generated by polish e-zdrowie.
I see an issue that QR code in wallet page is to small and scanner which is installed on another phone can’t read it. Have you tested that it is ok?

The dates on the imported pass display 00:00 as the time of birthday and vaccination. The dates should better display no time at all.

The USP labels make the Russian version wider than the screen width, they should break into two lines.

Leider funktioniert es nicht

Camera - violet ekran

Reported by @donatuswolf

May be an issue, as the current iOS15 Developer Beta is a quite early Beta version.

Makes it difficult to read with another phone's camera. Simply increasing the size of the QR code would help.

For testing, development and deploying the project, the documentation about how to get the needed certificate and information about the Apple Wallet pass should be improved.

Among others, good examples are:

• https://www.skycore.com/help/creating-pass-signing-certificate/
• https://www.passsource.com/info/certificateInstructions.php

Is your feature request related to a problem? Please describe.
Today I had my first attempt at getting the passport scanned. Done at a reception desk via a smartphone. Several attempts failed, however, as the QR was too small, including all glares etc. it turned out to be unreadable. I feel like this may be a common problem in places where they scan your codes via a relatively cheap/old smartphone.

Describe the solution you'd like
Larger QR code

Describe alternatives you've considered
I used the screenshot of my certificate that I had for backup

I have two devices (iPhone 12 Mini and XR)
I added the COVID Pass to my Wallet (not relevant to this issue, but it for some reason doesn't work with Chrome and only allows to add it to Wallet using Safari (iPhone XR didn't try with 12M.)

My certificate is Estonian and for vaccination. The actual issue for me for both phones is that I cannot scan the QR code because of low resolution maybe? Thanks to https://kontroll.digilugu.ee/ we can check for validity of the QR code and I cannot get it to read the QR code.

Sehr geehrtes Team von Covidpass.eu

meine ersten beiden QR codes konnte ich ohne Probleme in meine wallet laden beim dritten nun scheint es problematisch zu sein. In Safari erscheint das Scannfeld nach der Aktivierung der Kamera, aber dann passiert nichts. Wenn ich auf den oberen Bereich "mein Pass" drücke geht es zurück und wenn ich wieder auf scann QR code gehe versucht er das vorherig Bild zu laden, um dann wieder in den Kameramodus zu wechseln.

Was könnte das Problem sein?

Vielen Dank und viele Grüße

Hallo Donatus,

danke für die schnelle Antwort!
I am afraid, dass ist eher nicht dar Grund, ich habe es mit vier verschiedenen iphones probiert und mein normalerweise genutztes iPhone hat iOS 12.5. Das mit dem schieben habe ich schon versucht, ging aber auch nicht. Besonders eigenartig finde ich, dass ich vorher ohne Probleme die anderen codes scannen konnte. Leider ist keines der Geräte ist neu und in der Nähe von iOS15.

Gibt es noch andere Möglichkeiten die ich ausprobieren könnte? Übrigens passiert das gleiche wenn ich nun versuche die alten codes einzuscannen, scheint also irgendwas anderes zu sein. Die Einstellungen habe ich nicht geändert.

Vielen Dank und viele Grüße

–––

Moin,
er scannt nicht, obwohl Kamera zugelassen und Datenschutz Erklärung bestätigt.
Mit freundlichen Grüssen,

Geht bei mir nicht, habe ein altes iPhone 6 und Software 12.5.5. Vielleicht liegt es daran.
Danke und schöne Grüße.

As a user, I want to quickly grasp what this application offers me when I first access the page.

Describe the bug

Problems with corvidpass scan for wallet creation

To Reproduce
Steps to reproduce the behavior:

It wasn’t possible to scan the CovPass

Expected behavior
Full functionality like shown in demo video to create a wallet CovPass

Screenshots
If applicable, add screenshots to help explain your problem.

Smartphone (please complete the following information):

• Device: [iPhone13]
• OS: [iOS15.11]
• Browser [iPhone safari]
• Version [??]

after clicking on the “scan” button, the screen should scroll down, so the camera is in center

Currently not scannable because it is too small in the Apple Wallet

Since the pass contains sensitive information, the user might want to improve their personal privacy by preventing the access to Apple wallet from a locked screen.

At least with Face ID equipped devices it can be done from "Settings -> Face ID & Passcode -> Allow access when locked: Wallet"

It would be great if there will be possibility to import image or PDF as most of us have it as file.

I was able to add the qr code into CWA and Covpass.

Your Browser app (on iPhone / Safari) does not recognize the qr code and cannot be added.
There is no error message.

It's the qr code I got to testify my 2nd and final vaccination

Spacing between icons/checkmarks and text and the alignment between the three USPs is not correct

Using the common sizes for websites

I cant Scan a testresult from EcoCare

allways the Same Issue.

Code lässt sich scannen, Button für Wallet funktioniert aber nicht.
Gefühlt 100x probiert!!!

On iPhone 12 Pro, iOS 15.1 and iOS 15.2 one cannot remove the old outdates covid-pass from the wallet.

Hitting "the three dots" on wallet pass, displays only the pass and application information, but no any
options - including the missing "Remove pass" option.

Only way to remove the pass and replace it with a new one is to completely erase the phone which removes
everything from the wallet too.

While trying to scan my EU Digital covid certificate qr code. There is a red square on the qr code and nothing happens. So i can not have the pass. Am i doing something wrong?

Appreciate it your work and your great initiative. Thank you!

First of all, thanks for your project, having the pass in the wallet is so handy.
Atm there's just a texture saying to use Safari, but I haven't seen it in my first try and was wondering why your site wasn't adding the pass to the wallet since no warning was being shown.
I'd suggest a browser detection and a browser warning should appear when using it in another browser, so that the user is aware of it.

While people have different sized mobile phones I would highly recommend to make that QR code area/box much bigger as it is hard for people to read these codes from hands with other QR reading phone/device if they are so small. Just use the entire width, it would make much easier to check the CovidPass QR code (main purpose of the covid pass would be to check and validate).

Chosen pass type is generic, therefore styling includes:

• Color definitions
• Texts
• Icon
• Logo
• (Thumbnail)
• (Additional fields)

https://developer.apple.com/library/archive/documentation/UserExperience/Conceptual/PassKit_PG/Creating.html#//apple_ref/doc/uid/TP40012195-CH4-SW4

Kamera Zugriff erlauben? Wie?

I noticed that my COVID pass had an off-by-one error on all of the dates (both my birthdate and my vaccination dates). I think this is because new Date("datestring") interprets the argument in UTC, but returns a Date object in local time. This is problematic if, say, you live in the western hemisphere, and midnight in UTC is the day before in local time:

> const d = new Date("1980-01-01")
Mon Dec 31 1979 16:00:00 GMT-0800 (Pacific Standard Time)
> const locale = window.$nuxt.$i18n.locale
'en'
> const localeDateString = d.toLocaleDateString(locale, {
  year: 'numeric', month: 'numeric', day: 'numeric'
});
'12/31/1979'

This causes formatDateString in payload.js to return the wrong date.

Somewhat annoyingly, MDN calls out this failure mode but doesn't have any alternative recommendation, so I'm not really clear what the right way to do this is.

Bulgarian and Greek certificates contain the name spelled in cyrillic and greek respectively as shown below:

It might be really useful if besides the main spelling the pass also contains the standardized spelling (described in the OpenAPI spec) so it matches the way it's written in a passport or an id card to aid folks who are traveling internationally

“QR Code is not correct” although this QR code works with corona warn app.

offer a color selection for pride colors or typical vaccination certificate yellow

After scanning the QR-Code successfully the button „add to apple wallet“ does not upload it to the wallet. I’m using iPhone X with the lastest iOS version

Hi,
While this works in IPad, it seems not possible to give camera access on the iPhone for scanning..... ist this normal?
Thanks

There should be a a setting to remove the watermark.

Instead of our URL, the Generated by titled section of the pass shows pass.credits.value. Seems to be a translation issue.

Would be good to also replace the logo here with a back button to the previous page

Please add cookie consent for GDPR and ePrivacy compliance

Reason is the language selection cookie that is being set i18n_redirected

I just scan my Belgian EU Digital COVID Certificate’s QR code.
In the wallet certificate, the date of birth and date of vaccination are 1 day earlier than they should be.

When creating the zip file to sign with the server, the full pass json is included instead of only the hash, which contradicts with what is written in the README.

Since the QR codes store sensitive personal information as well as health data, processing of the data is done entirely within the users browser. Only a hash over the data is sent to the server to sign it with a certificate issued by Apple, for which a Apple Developer Program Membership is required.

The hash is being created but never used, https://github.com/philipptrenz/covidpass/blob/90c90fbf82ef606eb4992a01fcf9180321daafec/plugins/src/pass.js#L41

There should be an option to scan the qr code from pictures. Because if i have the file on my phone i cannot scan it only with my camera. If it is already there, then it should be more easier to find because I don’t see it on my iPhone 11.

Was thinking of making this. Thank you for the work, very appreciated.

Importing my Danish certificate results in my wallet pass showing my date of birth of-by-one (-1).

Is your feature request related to a problem? Please describe.
I have no printed version of my QR codes by hand. So I can't use your app to make a foto of it.

Describe the solution you'd like
Upload a screenshot of my vaccinated WR code from the Corona Warn app.