philburr / atsc Goto Github PK

Hi, thank you for this tool.

I'm not able to compile it, even though I know how to use cmake and I have cloned with --recursive.

I think the version of Catch2 that you're using is out of date, as I get compile errors from it. When I search for that error on the Catch2 repo, I find an issue mentioning that it is fixed in a later v2 release, so I replaced the submodule with the latest v2 Catch2 release. I got further, but now I get unused variable errors for variables which are definitely used (because I get "use of undeclared identifier" errors when I comment them out.)

I've tried with both gcc and clang/clang++ and I don't know C++ well enough to fix these.

More of a suggestion than an issue.

If you ever wind up with an arm64 device in your hands, a version of this that builds on arm64 would be wonderful. Bonus points if it compiles and runs on MacOS.

There are Intel instrinsics somewhere in this code and those obviously won't work on arm64 CPUs.

As I said, a "nice to have" and nothing more. I am not expecting you to do this, and I try to make that clear when I have suggestions like this. You don't owe me nuthin'.

Not sure you care much about this, but thought I would try and connect. Just compiled this on Linux (I've used ffmpeg for many years, so easy first step). However, neither w_scan on Linux nor a TV can find a usable stream. The signal is there, but with your version of ffmpeg and -metadata atsc_name and -metadata atsc_channel, w_scan concludes with:

tune to: 8VSB f=473000 kHz (0:0:0) (time: 03:35.506)
Info: no data from PAT after 2 seconds
Info: no data from VCT(terr) after 6 seconds

So before I start tearing into what PAT and VCT should contain that it doesn't, is this expected or something I'm not doing right? Either way, thanks for this project. Got me thinking about what is possible and playing.

I have a HackRF, and would like to use it with your ATSC encoder, but I need a couple things. I need a copy of this ATSC transmitter software compiled for Windows, and I also will need a compiled copy of the specially modified version of FFMPEG (which supports ATSC TS encoding) that I see you also have made. I see you have the source code for both of these, but I would like both of these compiled for Windows. I've tried compiling complex projects before, only to realize that I don't have certain dependencies (such as .h header files) with my Microsoft Visual C/C++ compiler (most of these I've heard come with the Linux version of GCC, but they don't exist with MS Visual C/C++). If you have access to the needed compiler, even if it's on a Linux box, and you need to cross-compile for Windows, please do so. I'd really like to try to go on the air with this software and my HackRF.