phetsims / area-model-multiplication Goto Github PK

First need to add a preference model and then we'll add the classes and structure for the character sets.

This branch (1.2) had changes related to the following applied:

• fix for iOS 13 Full Screen, see phetsims/phet-core#64
• phetsims/scenery#1006

Presumably one or more of these changes is likely to have been applied after the last RC version, and should be spot-checked by QA in the next RC (or if it was ready for a production release, an additional spot-check RC should be created).

The RewardNode from this sim's game shows variable terms ("x" and "x²"). It shouldn't since this sim does not use variables.

Seen on macOS 10.13.3 Chrome, master (noon?)

Test device
MacBook Air M1 chip

Operating System
14.3.1

Browser
Safari 17.3.1

Problem description
For phetsims/qa#1042 and phetsims/qa#1041 the banner size is smaller in the rc version than in published, leaving very little space around the Start Over button.

Visuals

Test device
MacBook Air M1 chip

Operating System
14.1.2

Browser
Safari 17.1.2

Problem description
For phetsims/qa#1032, I see the same issue as in phetsims/area-model-algebra#10: With ?stringTest=dynamic it is easy to see that the "Choose Your Level!" text is off-center on the Game screen in locales other than English.

Visuals

Design

• Sim folder and design doc created (Date: 01/19/2016)
  • Create sim folder in PhET Sim Design Folder using phet-docs account
  • Place design doc in the sim folder
• Sim suggestions doc reviewed
• Learning goals and standards identified (Date: 03/21/2016)
• Design concept complete (Date: 05/05/2016)
• Wireframes complete (Date: 08/31/2016)
• Mockups complete (Date: 06/08/2017)
  • Mockups checked for colorblind and greyscale
• Features for PhET-iO discussion
• Interviews complete (Date: //)
  • Results reported to team
  • Notes pasted into design doc
  • Back-up of interviews
• Lead designer "sign off" (Date: //)
  • Performance acceptable
  • Carefully review ?showPointerAreas
  • No new feature requests
• Pre-publication items
  • Main screenshot (2048x1344, PNG, 32-bit color, browser chrome stripped)
  • Auxilary screenshots (up to 3 additional)
  • Accessories (keywords, categories, description, learning goals, related sims, NSDL)
  • Teacher Guide created, uploaded, and added to sim design folder
  • Add an activity
  • Sim primer draft
  • Verify credits
• Post-publication items
  • Add the simulation to responsible_dev.md
  • Add to Edmodo
  • Add to Gooru (signed in as phethelp)
  • Sim primer (create issue, publish ideally within 1 month of live sim)
  • Hold postmortem if applicable (Date: //)

Implementation

• Repository created (Date: 08/31/2016)
  • simula-rasa used to create project skeleton
  • README.md created using grunt unpublished-readme
  • Collaborators added (such as QA team, designers, etc)
  • standard GitHub label set applied
  • repository added to chipper/data/ files
• Development started (Date: 05/09/2017)
• Sim is "feature complete" (Date: 1/12/2018)
• Code review completed (Date: //)
• Published (Date: 4/24/2018)
  • README.md updated using grunt published-readme (in master and release branch)

QA

• Dev testing started (Date: //)
• Dev testing completed (Date: //)
• First RC published (Date: //)
  • Test matrices put in Testing Matrices Folder
• RC testing completed (Date: //)

@jonathanolson demonstrated the latest version of Area Model Multiplication today and I noticed the sim has mostly white components on a white background. I don't recall any other sims that use the same white on white pattern. I'm not familiar with the design for the sim, but wanted to check whether that is under discussion. Having a different color for the area vs the background could help it stand out more. Assigned to @jonathanolson to evaluate and delegate to the design team.

This is an issue from area-model-common in phetsims/area-model-common#200. This has been fixed in main here: phetsims/area-model-common@1194306.

Leaving this issue open to be verified by QA in the next release cycle as it is a pretty minor bug.

Per @kathy-phet's request in phetsims/qa#295 I am making issues in each published sim repo detailing the pointer areas and usability of sims on phone sized screens. Done on an iPhone 7 iOS 12 device.

Potential Difficulties Noticed:

• None seen

Screenshots:

@mattpen can you apply the standard label set to this new sim repo?

Test device
MacBook Air M1 chip

Operating System
14.1.2

Browser
Safari 17.1.2

Problem description
For phetsims/qa#1032, the outline around the block in Level 1 is thicker than the other blocks.
@amanda-phet said this is something she would normally fix.

Visuals

While meeting, we realized AM sims don't have a gameLevels query parameter, similar to phetsims/graphing-lines#144.

This sim should have game sounds on and other UI sounds off.

Test device
MacBook Air M1 chip

Operating System
14.3.1

Browser
Safari/Chrome

Problem description
For phetsims/qa#1042, if the locale is changed while in a level on the game screen, the directive will no longer be centered above the play area. In some locales it is shifted left, while in others it is shifted right. Exiting the level and entering it again fixes the problem.

Steps to reproduce

1. Go to the game screen in any locale (ex. Spanish)
2. Select a level
3. Switch locales once in the level (ex. English)

Visuals

@Luisav1 don't forget to add yourself to the credits 🙂.
Also please update QA credits to include: Jaron Droder, Clifford Hardin and Nancy Salpepi

Tagging phetsims/qa#1042

For phetsims/joist#958 to use localizedImageProperty in Area Model Multiplication and Area Model Algebra.