pharo-spec / newtools Goto Github PK

Breaks extensibility of method.
They must be instantiated and returned from rootCommandGroupmethod.

Add possibility to sort by ab order.

The problem is that the error in the original debugger is masked, and we do not have any warning about it.

We have to manually go to the debugger list and select the session to debug.
However, we have to find it inside, and as the cache is limited to 5, we can really miss the bug.

Every new debugging tool seems to need a dedicated registry to hold its model instances.
This leads to writing a singleton each time, and we see many tools implementing its own singeton in class side.
Exemple: object-centric, halt cache, debugger selector, etc.

Could we think of another way? a better design?

• Evaluate in playground:

a := 2.
self halt.

• Click on the DoIt context.
• The #a variable does not appear in the list of temporary variables.

Fix all the tests and automate them

Add possibility to sort based on the method name or the halt type (breakpoint/halt)

When executing the Do It button with at least some code inside the playground a debugger appears.
I suppose it is a problem with the context given to the command or a missing method in StPlayground

MessageNotUnderstood: StPlayground>> #doItReceiver in SpCodeInspectItCommand(SpCodeSelectionCommand)>>evaluate:andDo:

(however it does work if I execute using Ctrl+D )

The method in question:

defaultTitle
	"GTDebugger needs this to create its action to switch to other debuggers (in this case to the Spec Debugger). I don't know if switching to this debugger actually works, but if the action cannot be created, the GTDebugger crashes when being opened. This method can be removed if the GTDebugger is removed"
	^ 'SpecDebugger'

As said in the comment, this method is only necessary for the GTDebugger to recognise SpecDebugger as a debugger (otherwise, it crashes).

NewTools-ObjectCentricBreakpointsTests package should have been "NewTools-ObjectCentricBreakpoints-Tests"

The debugger opens and we can create the method, but there is no indication of that

Hi,

I would like to get the FlagsBrowser to go in Pharo 7. However, when I load the NewTools baseline in a fresh image, I get the warnings below (I left out duplicates).

1) This package depends on the following classes:
  CmCommand
  SpPresenter
  SpApplication

2) This package depends on the following classes:
  SpApplicationConfiguration

3) This package depends on the following classes:
  StPresenter
  CmCommand
  SpPresenter

4) This package depends on the following classes:
  SpecDebugger

5) This package depends on the following classes:
  StInspection
  CmCommand

I understand that the new Spec 2 development is taking place in Pharo 8 and this might be tightly coupled to that. However, most people working with Pharo professionally for clients will want to work with the latest stable version. Like me :-)

The 'old' FlagsBrowser doesn't work either, because it's missing some code related to a notebook (page).

What would be a good way to resolve this? Please advise.

Kind regards,
Jonathan

It should not show utilitary or test halts present in the system (ideally there should not be any remaining halts in the system).

It is always false by default, while the settings browser shows it as "true".

For example: metalinks.
Add actions in the gutter icon to activate/deactivate/skip the meta-code.

• it shows meta of that tool object
• all commands are applied to that tool object instead of the selection

On an error or a failing test:

• If you close the window, tearDown is never called
• if you proceed, tearDown is called and your failing or erroring test... passes.

That's a super huge problem.
Also, I noticed that the process leak seems stronger when that happens.
It might be coming from the debugger.
This is super important to fix.

Stef's observation

For SpToolbar for example, we can only have icon on the top with text below, text only or icon only.
For the debugger we need to have buttons on the side.

Add tests

@dupriezt you have that in a helper method iconProvider.
Please fix.

(Not sure if the problem is concerned by the new debugger)
When trying to "close all debuggers" (from "Windows" button on the main menu).

so we can switch it and switch it back if needed

in general, debugger shows the error as part of the title.
now is showing just "DebugSession" and is hard to know what is happening.

I would like to have Text objects in StHeaderBar to put emphasis on the text.
Could that be generalized for all labels?

I can work on that but I want to discuss first.

• Actions from the debugger inspector selection
• Track/watch flavors:

1. watch var for all instances of a class
2. watch one var for one instance
3. watch one var and objects that reference its owner
4. ...

Add a browse button and/or a right click action on the selected method.

• Run in playground:

self halt.
a := Point x: 1 y:2.
Point new.

• Step into the call to #x:y:
• Use the Return button and type context as the expression to return.
• After this you should be in the DoIt context. Step over the assignment to the 'a' variable.
  The value of the 'a' variable (the first value of the operand stack of thisContext) is the Point class.
  However, there was no context variable in the context where we used the Return button, so the return value should have been nil (like it is when you type gibberish as expression to return) instead of the Point class.

DADependencyChecker new daPackageFor: 'NECompletion'.

debug that

dive until "build"

build
    "build the dependency graph"
    self 
        computeStaticDependencies;
        removeInternalDependencies;
        combineDependencies```

and then "through" when you are in computeStaticDependencies

Separate extension tools from the base debugger.
Ideally, each standalone debugging tool should be in its own package.

There is no need to have model separated from spec.

NewTools-FlagBrowser and NewTools-FlagBrowser-Tests should be enough.

Add a second chance to the memory selection when stepping into a new method of the same class: if something in the receiver was selected it should stay selected.

Test all debug commands and report issues for pb not easily fixable needed.

Each time I try to remove all stored sessions, it freezes my image and I have to kill it

https://github.com/Uko/MatchTool

In debugger selector classes, there are a lot of huge methods in initializeWidgets.
It looks like some of that behavior must be in ìnitializePresenters` instead.

These methods are also very compact and with a lot of code.
Could they be enhanced with more clean, clear code?

• use double dispatch on nodes to know what skipping strategy to use instead of switch case
• take into account nodes on which a bytecode step has been done (e.g. variable nodes receiver of messages)

That may not be simple, as depending on the parent (e.g., assignment or message or...?) what we have to pop from the context and how much we should advance the pc is not obvious.

For example, inspecting something through the contextual menu opens an inspector but also restarts the method.

Smalltalk tools debugger always gives the GT debugger, even if we register another one.
Executing Halt now will open the correct debugger (e.g. Spec).