Coder Social home page Coder Social logo

Comments (5)

vlsi avatar vlsi commented on June 28, 2024 1

In fact, the current implementation of reset resets the cached data, so there's no much value in testing mix of read/mark/reset calls.

mark/reset is tested in org.postgresql.test.jdbc2.BlobTest#markResetStream

from pgjdbc.

davecramer avatar davecramer commented on June 28, 2024

Thanks for the suggestion.
Pull requests are welcome.

from pgjdbc.

OrangeDog avatar OrangeDog commented on June 28, 2024

I don't see any existing tests for the class. LargeObjectManagerTest does a basic read but that seems to be it?
StrangeInputStream implements skip, but nothing ever calls it.

from pgjdbc.

vlsi avatar vlsi commented on June 28, 2024

I guess we do not have specific tests for skip as we used the default implementation.
Sure if we add a custom implementation, we'll need to cover it with tests.

The mix of read + mark + skip + reset might be problematic for testing.

from pgjdbc.

OrangeDog avatar OrangeDog commented on June 28, 2024

You have implemented mark, reset, and close, but there are apparently no tests for those. I am happy to add this feature, but I don't really want the burden of testing the whole thing from scratch. Unless I simply haven't found the tests?

from pgjdbc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.