peterwooley / bonusxp Goto Github PK

Instead of polling with the onUpdate event, only update tooltip info when a relevant event changes the data.

Something like BonusXP:getDetails() that returns the current percentage bonus and a table of details.

Detecting words of wisdom and enlisted fine, but not detecting any heirlooms at all. Tried re-equipping but made no difference.

LUA Error:

x2 BonusXP\BonusXP-1.3.1.lua:718: attempt to index local 'item' (a nil value)
Stack: [string "@BonusXP\BonusXP-1.3.1.lua"]:718: in function 'onEventHandler'
[string "@BonusXP\BonusXP-1.3.1.lua"]:784: in function <BonusXP\BonusXP.lua:783>
Time: 2020/07/05 02:12:15 Index: 2/2
RealUI Version: 2.2.0
Locals:
self = {
getMapTopParentInfo = function @BonusXP\BonusXP.lua:195
updateTooltipText = function @BonusXP\BonusXP.lua:552
calculateEquipment = function @BonusXP\BonusXP.lua:489
getDetails = function @BonusXP\BonusXP.lua:851
getItemLinkInfo = function @BonusXP\BonusXP.lua:795
refreshSpellData = function @BonusXP\BonusXP.lua:398
setup = function @BonusXP\BonusXP.lua:769
readFullItemData = function @BonusXP\BonusXP.lua:748
isMemberVisible = function @BonusXP\BonusXP.lua:332
updateBuffListText = function @BonusXP\BonusXP.lua:621
getGroupInfo = function @BonusXP\BonusXP.lua:344
registerEvents = function @BonusXP\BonusXP.lua:225
getAuraXpBonus = function @BonusXP\BonusXP.lua:298
refreshEquipDataSlot = function @BonusXP\BonusXP.lua:432
isWowAnniversaryAura = function @BonusXP\BonusXP.lua:282
getItemAuraXpBonus = function @BonusXP\BonusXP.lua:270
onPlayerReady = function @BonusXP\BonusXP.lua:643
getContinentId = function @BonusXP\BonusXP.lua:204
updateButton = function @BonusXP\BonusXP.lua:791
updateRAFText = function @BonusXP\BonusXP.lua:574
updateUI = function @BonusXP\BonusXP.lua:241
updateTooltipSize = function @BonusXP\BonusXP.lua:261
updateBuffText = function @BonusXP\BonusXP.lua:559
refreshEquipData = function @BonusXP\BonusXP.lua:477
updateGearInfo = function @BonusXP\BonusXP.lua:540
calculateBonus = function @BonusXP\BonusXP.lua:249
initialize = function @BonusXP\BonusXP.lua:211
onEventHandler = function @BonusXP\BonusXP.lua:656
updateEquipmentListText = function @BonusXP\BonusXP.lua:632
updateEquipmentText = function @BonusXP\BonusXP.lua:588
getSpInfoBonus = function @BonusXP\BonusXP.lua:276
}
self = nil
event = "HEIRLOOMS_UPDATED"
arg1 = nil
arg2 = nil
arg3 = nil
arg4 = nil
arg5 = nil
cnt = 8
(for index) = 1
(for limit) = 8
(for step) = 1
i = 1
itemId = nil
item = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = "attempt to index local 'item' (a nil value)"
isPlayerReadyFired = true
BonusXP = {
getMapTopParentInfo = function @BonusXP\BonusXP.lua:195
updateTooltipText = function @BonusXP\BonusXP.lua:552
calculateEquipment = function @BonusXP\BonusXP.lua:489
getDetails = function @BonusXP\BonusXP.lua:851
getItemLinkInfo = function @BonusXP\BonusXP.lua:795
refreshSpellData = function @BonusXP\BonusXP.lua:398
setup = function @BonusXP\BonusXP.lua:769
readFullItemData = function @BonusXP\BonusXP.lua:748
isMemberVisible = function @BonusXP\BonusXP.lua:332
updateBuffListText = function @BonusXP\BonusXP.lua:621
getGroupInfo = function @BonusXP\BonusXP.lua:344
registerEvents = function @BonusXP\BonusXP.lua:225
getAuraXpBonus = function @BonusXP\BonusXP.lua:298
refreshEquipDataSlot = function @BonusXP\BonusXP.lua:432
isWowAnniversaryAura = function @BonusXP\BonusXP.lua:282
getItemAuraXp

When joining a party, an error is thrown referring to a missing table.

When a player is in range, it should be possible to inspect another player's buffs and gear to determine their bonus XP.

Shadowlands is removing XP bonuses for heirloom gear. Remove the UI section and any associated code that erroneously reports an XP bonus that no longer exists.

In Shadowlands, the MAX_PLAYER_LEVEL_TABLE table is removed and replaced with the GetMaxLevelForExpansionLevel function. Switch to this new function and make it backward-compatible ahead of the 9.0.1 pre-patch.

Instead of showing as a tooltip, add the Bonus XP UI to the bottom of the character stats pane. That way, it won't cover up content for some better geared characters and it should work with ElvUI.