peteretep / calc Goto Github PK

The inline javascript should be moved to the external coffeescript file.

should lint the code to adhere to ruby conventions.
this plugin may be useful
https://github.com/pderichs/sublime_rubocop

Decimal answers are likely when you divide two ints. Therefore the result field nees to be a float / double / whatever

The calculations_controller has too many lines and has too much repetition.
It counld be made more concise and DRY'er

Need to learn about testing and write tests.

Stupid little bug - the page loads the last record in the DB - if there's none it errors out.

Decimal inputs are being allowed by the front end.
The server is doing integer calculations for operations except for division.
This is not good.

Should be fixed in two places -

• Client should check that inputs are int values and only enable submit boxes if they are.
• Server should check that inputs are ints and return an error if not.

The calculator currently uses the default sqlite development DB.
MongoDB is preferred.

It's currently possible to submit a blank form.
Enter two values and submit the form.
The form is submitted and is reset, and disabled until the server responds.
The form is then reenabled.
The submit button should not be re enabled until two valid values are input

The input boxes should use the html5 number input type.
See http://www.w3schools.com/html/html5_form_input_types.asp

Calculator must operate only on non-negative integer numbers lower than 100.
The form is disabled by javascript if invalid values are input, but server side error trapping is also required to be safe.

At the moment, the form only does addition. Not good obviously.
Sum, difference, multiplication and division are all required.

The interface looks a bit gammy still.
Inputs should be made smaller.
Extra buttons for other operations are needed.