petar-dambovaliev / darpi Goto Github PK

The path_type and query_type macros generate pretty much the same code for every input.

path_type builds in a slightly custom deserialization function to each struct property (wrapping the deserialization error in a custom struct), but I expect that that could be implemented outside of the macro (i.e. in the library code when it tries to deserialize the struct.

query_type doesn't modify the struct and the trait impl it creates is the same every time (it doesn't need to be created special for each struct).

In case one of these macros is still necessary, I would recommend using a derive macro instead of a full attribute macro.

The shaku module is passed in as a type reference. This prevents users from customizing it (passing parameters or overriding services).