petabyt / fudge Goto Github PK

My recently upgraded scanner today reports on your update:

! repo/dev.danielc.fujiapp_5.apk declares risky permission(s): android.permission.READ_EXTERNAL_STORAGE*

This is an "implied permission" (Android automatically grants that when WRITE_EXTERNAL_STORAGE is requested. Seeing that one needs at least Android 5 to run your app, and that there's SAF (Storage Access Framework) available to deal with file system operations: Does your app really need that permission (and what for then), or could it be dropped?

Thanks in advance for clarification!

Fujiapp log file - Send this to devs!
ABI: arm64-v8a
Compile date: Jul 11 2023
https://github.com/petabyt/fujiapp
Running test suite from C
send_bulk_packets 0x1002 (PTP_OC_OpenSession)
send_bulk_packet: Sent 16 bytes
Failed to read 8 bytes
Failed to open session

When I try to connect again a few times it'll appear as if its working

Fujiapp log file - Send this to devs!
ABI: arm64-v8a
Compile date: Jul 11 2023
https://github.com/petabyt/fujiapp
Running test suite from C
send_bulk_packets 0x1002 (PTP_OC_OpenSession)
send_bulk_packet: Sent 16 bytes
recieve_bulk_packets: Read 12 bytes
recieve_bulk_packets: Return code: 0x2001
Opened session
send_bulk_packets 0x1015 (PTP_OC_GetDevicePropValue)
send_bulk_packet: Sent 16 bytes
recieve_bulk_packets: Read 62 bytes
recieve_bulk_packets: Return code: 0x2001
Recieved events after opening session.
Payload: 06 00 00 DF 06 00 00 00 20 D2 01 00 00 00 22 D2 7B 00 00 00 2F D5 01 00 00 00 00 D4 01 00 00 00 01 D4 7B 00 00 00
send_bulk_packets 0x1015 (PTP_OC_GetDevicePropValue)
send_bulk_packet: Sent 16 bytes
recieve_bulk_packets: Read 26 bytes
recieve_bulk_packets: Return code: 0x2001
Read property 0xDF00 (2 bytes)
Payload: 06 00
send_bulk_packets 0x1015 (PTP_OC_GetDevicePropValue)
send_bulk_packet: Sent 16 bytes
recieve_bulk_packets: Read 26 bytes
recieve_bulk_packets: Return code: 0x2001
Read property 0xDF01 (2 bytes)
Payload: 00 00
send_bulk_packets 0x1015 (PTP_OC_GetDevicePropValue)
send_bulk_packet: Sent 16 bytes
recieve_bulk_packets: Read 28 bytes
recieve_bulk_packets: Return code: 0x2001
Read property 0xDF21 (4 bytes)
Payload: 03 00 00 00
send_bulk_packets 0x1015 (PTP_OC_GetDevicePropValue)
send_bulk_packet: Sent 16 bytes
recieve_bulk_packets: Read 28 bytes
recieve_bulk_packets: Return code: 0x2001
Read property 0xDF22 (4 bytes)
Payload: 04 00 00 00
send_bulk_packets 0x1015 (PTP_OC_GetDevicePropValue)
send_bulk_packet: Sent 16 bytes
recieve_bulk_packets: Read 28 bytes
recieve_bulk_packets: Return code: 0x2001
Read property 0xDF23 (4 bytes)
Payload: 01 00 00 00
send_bulk_packets 0x1015 (PTP_OC_GetDevicePropValue)
send_bulk_packet: Sent 16 bytes
recieve_bulk_packets: Read 28 bytes
recieve_bulk_packets: Return code: 0x2001
Read property 0xDF24 (4 bytes)
Payload: 04 00 02 00
send_bulk_packets 0x1015 (PTP_OC_GetDevicePropValue)
send_bulk_packet: Sent 16 bytes
recieve_bulk_packets: Read 28 bytes
recieve_bulk_packets: Return code: 0x2001
Read property 0xDF25 (4 bytes)
Payload: 02 00 00 00
send_bulk_packets 0x1015 (PTP_OC_GetDevicePropValue)
send_bulk_packet: Sent 16 bytes
recieve_bulk_packets: Read 24 bytes
recieve_bulk_packets: Return code: 0x2001
Read property 0xDF26 (0 bytes)
No payload
send_bulk_packets 0x1015 (PTP_OC_GetDevicePropValue)
send_bulk_packet: Sent 16 bytes
recieve_bulk_packets: Read 28 bytes
recieve_bulk_packets: Return code: 0x2001
Read property 0xDF31 (4 bytes)
Payload: 02 00 00 00
Waiting for device access...
send_bulk_packets 0x1015 (PTP_OC_GetDevicePropValue)
send_bulk_packet: Sent 16 bytes
recieve_bulk_packets: Read 26 bytes
recieve_bulk_packets: Return code: 0x2001
send_bulk_packets 0x1016 (PTP_OC_SetDevicePropValue)
send_bulk_packet: Sent 16 bytes
send_bulk_packets 0xB (PTPIP_CANCEL_TRANSACTION)
send_bulk_packet: Sent 16 bytes
recieve_bulk_packets: Read 12 bytes
recieve_bulk_packets: Return code: 0x2001
Gained access to device (or already have access)
Configuring mode property
send_bulk_packets 0x1015 (PTP_OC_GetDevicePropValue)
send_bulk_packet: Sent 16 bytes
recieve_bulk_packets: Read 26 bytes
recieve_bulk_packets: Return code: 0x2001
send_bulk_packets 0x1015 (PTP_OC_GetDevicePropValue)
send_bulk_packet: Sent 16 bytes
recieve_bulk_packets: Read 28 bytes
recieve_bulk_packets: Return code: 0x2001
Version uint32 was 20004
send_bulk_packets 0x1016 (PTP_OC_SetDevicePropValue)
send_bulk_packet: Sent 16 bytes
send_bulk_packets 0x2001 (PTP_RC_OK)
send_bulk_packet: Sent 16 bytes
recieve_bulk_packets: Read 12 bytes
recieve_bulk_packets: Return code: 0x2001
Mode property is configured.
Configuring FunctionMode
send_bulk_packets 0x1015 (PTP_OC_GetDevicePropValue)
send_bulk_packet: Sent 16 bytes
recieve_bulk_packets: Read 28 bytes
recieve_bulk_packets: Return code: 0x2001
send_bulk_packets 0x1016 (PTP_OC_SetDevicePropValue)
send_bulk_packet: Sent 16 bytes
send_bulk_packets 0x2001 (PTP_RC_OK)
send_bulk_packet: Sent 16 bytes
recieve_bulk_packets: Read 12 bytes
recieve_bulk_packets: Return code: 0x2001
Configured FunctionMode, no errors detected (yet)
Trying to get SD card info...
send_bulk_packets 0x1004 (PTP_OC_GetStorageIDs)
send_bulk_packet: Sent 12 bytes
recieve_bulk_packets: Read 28 bytes
recieve_bulk_packets: Return code: 0x2001
No storage devices found!
We got to the end of the test, and nothing broke :)
Ending test...

Trying to connect again after this results in Failed to init socket
The OS on the camera stays on the app connection init screen as if nothing had happened

Camera gets stuck here, "Ok" button does nothing

your latest release is signed using a key different from the one in place before:

WARNING: "dev.danielc.fujiapp_2.apk" is signed by a key that is not allowed:
5995c87f0ba43a21d14f715598eb716f399951a9a3f4e7af62a89c3adb9f5e17

I found no corresponding note on the release. May I ask what happened? Note that updates won't make it into my repo until the issue has been resolved.

PS: If you wonder about the file name, that is your app-release.apk being automatically renamed to <packageName>_<versionCode>.apk so it can co-exist with the others.

When image is selected and downloaded, sometimes the thumbnails will continue to download (the calls are queued). This causes the progress bar to jump around and skip, until the image download starts.

If I Can help... But I am not a developer...
Thank for the work

Might be a simple fix with transfer mode

Great you're making the app publicly available open-source! Digging in the code I see it's put under GPL-2.0 😍 Could you please add the LICENSE file to the repo root to make that more obvious (so one hasn't to dig in the code to find out)? Thanks in advance!