perun-network / perun-polkadot-pallet Goto Github PK

It is currently possible to dispute channels that were never funded. This could be used to inflate the on-chain state.
Im not sure if it is really a problem but it seems weird since the on-chian state should be minimal.

Add CodeCov to the CI so that it shows up here: https://app.codecov.io/gh/perun-network/perun-polkadot-pallet.
Seemed to work in the past.

Currently, we store the full state on-chain. However, as an optimization we could only store the hash of the state and provide the state always in the calldata. Then we simply check whether the hash of the provided state matches the hash in the state registry. Thereby we save on-chain storage.

Remove the markdown-link-check-disable from the README once the node repo is public.

The number of participants, and therefore the number of off-chain signatures is currently not limited.
The implementer should also check for other cases of arbitrary long inputs.

To get some deterministic bench-marking results, all inputs should have defined maximum lengths.

Currently, the Pallet does not allow to recover funds from an unfunded channel. A dispute conclusion will just fail in this case.

We need to revise the Pallet so that we payout the initial deposits in case of an underfunded channel.

Currently, the conclude functionality has two writes:

1. Set the outcome.
2. Conclude the registered state.

Problem: There is a risk that the first transaction goes through, while the second fails. In this case we might end up in an inconsistent state.

We need to investigate further whether the current solution is problematic and if so, how to resolve the situation. Maybe using the transaction decorator might be a solution, as pointed out here.

The version is a small object. Shouldn't be a problem to persist it.

Originally posted by @matthiasgeihs in perun-network/perun-polkadot-backend#3 (comment)

Time durations and time points currently both use Seconds which is not easy to understand.
Either add two different types or at least alias them.