personium / app-myboard Goto Github PK

View Code? Open in Web Editor NEW

2.0 2.0 6.0 222 KB

An application that runs on the home application. Sample memo app.

License: Apache License 2.0

CSS 4.68% JavaScript 91.48% HTML 3.84%

ajax i18next javascript jquery personium personium-app

app-myboard's People

Contributors

Stargazers

Watchers

Forkers

atsx dixonsiu mhciael cskyou takasugimoto yoh1496

app-myboard's Issues

Get Box URL using API

Should display who's board the user is viewing

Currently there is no way to identify whose board is displayed because user/cell name is not displayed.

Renovate UI with similar design as HomeApp and Calorie Smile Sync

Correction due to specification change of Personium Core Request message

If you want to browse the myboard of others, it does not work properly when the box name is different from their own

Add function to add ending slash automatically to Unit/Cell/Box URL

getBoxUrlFromResponseHeader uses login user's URL accidentally

It should use target Cell URL when Location header is not found.

Suggestion: Maybe it is better to check the response since it is working now.

Cannot access friend's box

Similar issue here.

Add personium:localunit support

Since HomeApplication has start supporting local URL (pesonium:localunit), external cell URL received from user's cell must be converted.

ReadBy list does not get rerendered

Need to add callback to Common.approvalRel.

No installation information

Since it is a sample app, the followings are missing:

Where to host the server side files
How to set up the server
What is needed to see this app from HomeApp
What is needed to install this app on to HomeApp
What is needed to view other data subject's cell

Manage permission using Role instead of Relation

Change APIs to use Role's parameters/values
Delete relation and link files in Barファイル

Content-type is set twice and an error occurs

personium.getAppAuthUserToken = function(query, token) {
        var cellUrl = query.cellUrl;
        var url = [
            cellUrl,
            "__token"
        ].join("");
        var headers = {
            "Accept": "application/json",
            "content-type": "application/x-www-form-urlencoded"
        };
        var contentType = "application/json";
        var body = [
            "grant_type=authorization_code",
            "code=" + query.code,
            "client_id=" + personium.getAppCellUrl(),
            "client_secret=" + token
        ].join('&');
        var httpCodeExpected = 200;
        
        return personium.httpPOSTMethod(url, headers, contentType, body, httpCodeExpected);
    };

Wrong button label displayed when reading another MyBoard

Since the user does not have write permission, the Edit button should be disabled or the label changed.

When displaying another MyBoard, 403 errors are displayed

Is it normal to encounter 403?

Navigation bar title (English) must be shortened

Currently the Japanese version uses the same sentence in the title and the description. However, it is more readable if we shorten the title. This is done by defining two keys in translation.json.

e.g. English json
{
"navbar": {
"readAnotherBoard": {
"title": "Other MyBoard",
"description": "Read another MyBoard"
}
}

Disable button when there are no options

To improve usability, instead of displaying "Please select a board.", it is much better to disable the button when the drop down menu is empty.

"personium-localunit:" URL is not converted

Bug

The URL sometimes is in the format of "personium-localunit:/".

Proposed fix

var url = Common.changeLocalUnitToUnitUrl(extUrl);
Common.dispAllowedCellListAfter(url, i);

Error message not displayed on the Read another panel

When the list of MyBoard is empty and the Read button is clicked, an error message should be displayed. Currently, the message is written in the DOM element but not displayed.

Solution 1: To improve usability , the Read button should be disabled.
Solution 2: Display the error message.

Roles.json is not up to date

Roles.json does not contain latest role and descripton.

Should remove the logic where br tag is inserted

Since we are using jQuery's val method, it is not necessary to convert newline to br tag.

New browser window is opened when reading another MyBoard

Should make good use of AJAX and replace the information inside the textarea.

More secure way to get token

Retiring getAppAuthToken service endpoint.

Deprecated format of Cell URL is used

Related issue in HomeApp

To be modified

changeLocalUnitToUnitUrl

GET https://demo.personium.io/hn-user-9001/io_personium_demo_app-myboard/MyBoardBox/my-board.json 404 (Not Found)
{"code":"PR404-DV-0002","message":{"lang":"en","value":"Box not found at [https://demo.personium.io/hn-user-9001/io_personium_demo_app-myboard]."}}

GET https://demo.personium.io/hn-user-9011/io_personium_demo_app-myboard/MyBoardBox/my-board.json 404 (Not Found)
{"code":"PR404-DV-0002","message":{"lang":"en","value":"Box not found at [https://demo.personium.io/hn-user-9011/io_personium_demo_app-myboard]."}}