persistenceone / persistence-sdk

Node modules and client utilities to build Persistence platform node applications.

persistence-sdk

Node modules and client utilities to build Persistence platform node applications.

persistence-sdk's Issues

Test case failure fixes

Splits Wrap and unwrap

Split wrap, wraps a coin (eg. 100 uatom , sdk.Int) and assigns it to 100.00.......0 sdk.Dec.
Once wrapped these splits are allowed to be sent across, (eg. 0.00005 uatom) will be allowed to be sent

And while unwrap transaction the decimals are left behind.

Send splits to random identityID goes through.

When send Splits transaction is called and the ToID is not present in blockchain, the splits module makes a entry of the randomIdentityID corresponding to the ownableID.

All Datas in types/base have Equal Methoda written incorrectly

All Data(HeightData, IDData, etc.) have Equal function written wrongly. Dec Data Equal method calls itself recursively and other Data's Equal method call DecData type's Equal because the match case is written wrongly.

takerID in orders is not getting parsed in properties.

mutableProperties go in as takerID:I|test.classificationID|hashID here there are two | .

TODO in module initialize

the genesis takes in (nil, nil) as paramters.

Add identity verify to identites mutate

IsProvisioned and IsUnprovisioned methods panicking inside identities, possibly related to the search method of listData

Unable to do asset and order define when leaving immutableTraits, mutableTraits fields empty

Got error
"code": 4, "raw_log": "unauthorized: signature verification failed; verify correct account sequence and chain-id"

The issue might be happening in other transactions and fields also.

Add verify identity to indetity quash

in modify keeper, negative split value being transferred

command AssetNode version, doesn't show version.

assetNode version command returns empty, in cosmos ecosystem, it shows commit ID/ tagged version.
Similarly with assetClient

TODO in fact signing

MetaFact signing is a todo since long,
The implementation in base/fact.go for signing, will always panic because context.NewCliContext does not initialise with a keybase.
Also we would want the signing to happen at the client end itself.

Queries to take in special parameters.

Example:
query splits for single account.
query orders for specific Identities.
query identities associated with a set of addresses/ single address

--- Feature Request ---

Maintainers module

Maintainers module addition is missing in schema/applications/base/application.go := sdkTypesModule.NewManager and SetOrderInitGenesis

maintainers.Module.Initialize() has not been given auxiliary keepers as parameters, which when given, causes looping in auxlilary, since identities transactions require maintainer auxiliary, and maintainer transactions require identities auxiliary.

and modules/maintainers/transactions/deputize/request.go needs govalidator fix.

Methods to Provision and UnProvision addresses inside identities not working

Identity Queries return genuine identity values for partial key queries

Mutate Asset does not check if fromID owns the asset.

Test scenario:

1. Maintainer mints an asset
2. Maintainer transfers the asset to another Identites so that the maintainer no longer has any asset left
3. Maintainer tries to mutate asset which is not owned by maintainer.
   This test cases goes through.

KV Stor prefix clash

3 Stores have kv store prefix clashing.

RemoveData throwing panic in case of nil values

AssetNode Export of persistence modules

fails when persistenceSDK transactions have been done.

Splits specific query not working

SplitsID key takes FirstOrderSeparator instead of secondOrderSeparator.

Add identity verify to deputize auxiliary

Meta ID: Same hash id is generated for different data type with same value.

Transactions override the data in the meta KV store when the hash id generated is the same (happens for default cases and when the metaData is of different type but has the same value as string).

Todo's left to implement

The following files have incomplete code (some todos commented out, yet to be implemented)

• modules/identities/internal/transactions/define/keeper.go
• modules/identities/internal/transactions/provision/keeper.go
• modules/identities/internal/transactions/quash/keeper.go
• modules/identities/internal/transactions/unprovision/keeper.go

GetList functions returning reference instead of List causing errors in properties.go and metaProperties.go

Not throwing Entity not found Error in case of a random classificationID

In classifications/auxiliary/conform/keeper.go , the error EntityNotFound is not thrown in case of a random classificationID.

Refactor maintainers verify auxiliary string name.

Unable to query transaction hash.

Getting the following response on a successful tx when querying its hash:
{ jsonrpc: "2.0", id: -1, error: { code: -32603, message: "Internal error", data: "runtime error: invalid memory address or nil pointer dereference" } }

Nil case not handled for split

In splits auxiliaries, nil case for no split is not properly handled in transfer/keeper.go.

TODO in keeper for maintainer check while issue/mint/make

There is todo for checking if the fromID is a maintainer which creating/ mutating assets or identities or orders.
Does this require a verify auxiliary in maintainer module?

identity issue is incorrect, to address not handled correctly in keeper

classification/identity query and query responses not handled correctly for random queries

Maintainers Module initiailization.

Identity module and maintainer modules need to be decoupled.
Its auxiliaries are called inside the init function of each other. Causing Maintainer Deputize transaction to throw nil pointer exception.

branch - master
commit - eb6bc10

Add identity verfy to identity revoke transactions

PersistenceSDK msgs and tendemint/Sig do not create same signatures.

The packageCodec defined in internal/common of each module, does not register message structs of transactions and is being used to Marshal the struct.

branch - master
commit - eb6bc10

Module event emitted in transaction.go HandleMessage incorrect

lines in [schema/helpers/base/tranaction.go ~ HandleMessage](https://github.com/persistenceOne/persistenceSDK/blob/004063432009880b4fdb087d35434372f84fdc46/schema/helpers/base/transaction.go#L76-L81l)

context.EventManager().EmitEvent(
		sdkTypes.NewEvent(
			sdkTypes.EventTypeMessage,
			sdkTypes.NewAttribute(sdkTypes.AttributeKeyModule, transaction.name),
		),
	
)

Here the Attribute key is Module, while transaction name is being passed.
Ideally it should be module.name (or message.Route()), since cosmos-sdk already appends AttributeKeyAction (as msg.Type())

Define more efficient list data compare method

Add and Remove methods not working inside listData

Staking & Sending malfunction with KEPLR & Ledger Nano X

There seems to be an issue with the Ledger Nano X and KEPLR when using the Persistence Wallet. Every time I click “approve” to initiate a transaction (for sending or staking) the transaction is immediately rejected and I get “Data is invalid : Unexpected characters”. The latest version of the ATOM app was running on the Nano X but it did not display anything special (no dialog appearing). Setting up the Persistence wallet and connecting the Nano X through Keplr worked fine. I am using Brave 1.26.67 on Windows 10 (German locale). I also tried Ubuntu Linux with Brave and got the same issue.

Unable to sell assets with splits, where taker gives more splits than he is supposed to

Expected Behaviour:
excess splits should be returned to the taker.
and the asset should be exchanged.

But getting:
{"height":"1929","txhash":"2C8F3501D9405A36F787574A48F014FF4ECABD566885E6CA21B71BE09C91F785","codespace":"/xprt","code":109,"raw_log":"NotAuthorized: failed to execute message; message index: 0"}

Order Make Tx: Cannot change exchange rate once order is created without adding more makerOwnableSplit

To change only the exchange rate, giving maker ownable split value 0 fails the tx because the makerOwnableSplit is Dec{ nil } that fails the tx. Hence to change the exchange rate one has to add some amount of maker ownable to the order. Also, for assets, this becomes impossible because there is no split left to add once the order is created.

Changing auxiliaryRequest.Split.LTE to auxiliaryRequest.Split.LT in splits/auxiliares/transfer/keeper, tx still fails when there is no split left of the ownable ID (fromSplit of fromSplitID is nil, as in the case of assets).

assetNode export command not working.

assetNode export gives the following response

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x18 pc=0x1065a7f]

branch master-

version: 0.1.0-13-gdb2e7fd
commit: db2e7fd

Order Make Expiry and MakerOwnableSplit

While define order - those fields are compulsory to be added for order to work.
while making order - if we send the expiry and makerOwnableSplit as mutables, then they are again appended by the keeper.

Need to either check for duplicate property ID's before appending, or resolve the transactionRequest struct, so it works via mutables only!

ValidateStruct fails for structs that have bool members and their value is set to false

Data type of property are allowed to be of different type than what was used to create the definition of the entity.

For example, if Identity Define was created using the following mutable Traits "mutableTraits":"OfficialHolidays:S|,PartyTime:S| and while issuing an identity it is changed to "mutableProperties":"OfficialHolidays:S|Christmas,PartyTime:H|12" (making PartyTime property from S type to H type), the transaction goes through successfully. The respective entity also takes this property with this different data type (taking H) under the same classification (where it is S). Hence this might be affecting Meta module too.

Add identity verify to deputize identity

Definitons and their entities are being allowed to have multiple properties with same property id.

When defining any classification or its entity, multiple properties with the same property id is allowed. An entity can have then multiple values for the same property.

UnWrap Splits

Unwrapping a non int amount of split, truncates the coins, and coins are lost.

NewIdentityID and NewAssetID has different input parameters.

NewIdentityID and NewAssetID has different input parameters.

NewIdentityID (classificationID, immutablesHash)
NewAssetID ( classificationID, immutables) //hash is calculated inside the function.

need to normalise