peridot-php / peridot-code-coverage-reporters Goto Github PK

Hello,

There is an issue with the method CodeCoverageReporter::addDirectoryToBlacklist. it calls the method Filter::addDirectoryToBlacklist that does not exist, so this method throws a fatal error. I think it should use the method removeDirectoryFromWhitelist.

Note that it is the same thing for addFileToBlacklist

Regards,

I'm a little confused by the other issues, and maybe I got it all wrong. But my impression was: Install the plugin, add the snippets from README to my peridot.php and run peridot with my xdebug-enabled PHP executable?
As I'm doing this, I receive the following error:

PHP Fatal error:  Uncaught Error: Class 'Peridot\Reporter\CodeCoverageReporters' not found in /Users/mo/PhpstormProjects/foundation/peridot.php:18
Stack trace:
#0 [internal function]: Peridot\Console\Environment->{closure}(Object(Evenement\EventEmitter))
#1 /Users/mo/.composer/vendor/peridot-php/peridot/src/Console/Environment.php(119): call_user_func(Object(Closure), Object(Evenement\EventEmitter))
#2 /Users/mo/.composer/vendor/peridot-php/peridot/src/Console/Environment.php(80): Peridot\Console\Environment->includeConfiguration('/Users/mo/Phpst...')
#3 /Users/mo/.composer/vendor/peridot-php/peridot/src/Console/Environment.php(57): Peridot\Console\Environment->loadConfiguration('/Users/mo/Phpst...')
#4 /Users/mo/.composer/vendor/peridot-php/peridot/src/Console/Application.php(211): Peridot\Console\Environment->load('/Users/mo/Phpst...')
#5 /Users/mo/.composer/vendor/peridot-php/peridot/src/Console/Application.php(43): Peridot\Console\Application->validateConfiguration()
#6 /Users/mo/.composer/vendor/peridot-php/peridot/ in /Users/mo/PhpstormProjects/foundation/peridot.php on line 18

Composer autoloading works flawlessly otherwise, I'm using Leo already and it's great. But I'd like to get code coverage reporting for my tests, so there seems to be something going seriously wrong here.

Hi, I do not management to get it to report code coverage. Do I need to put any parameters in terminal on run?

I think having "Peridot\Reporter" in the psr-4 config is too tight. Other reporter plugins will have a hard time making use of that. Should probably be something like "Peridot\Reporter\CodeCoverage" - see the dot reporter for an example.

This library is not as useful as a collection of reporters. It really should just function as a plugin that honors the reporter being used. That way we get output + coverage :)

I imagine most of the code would be the same, but we would use the same events, but stop using the reporter api to hijack the output.

I would vote creating a new package and just deprecating this one adding a "recommended" package of the new solution to the composer.json

README wanted.