pepijn / omni_kassa Goto Github PK

In omni_kassa/response.rb response code 90 is handled as a pending response. However in the documentation I received from Rabobank ("Integratiehandleiding Rabo OmniKassa, versie 7.1, april 2014") it is being defined as:

• Page 31,
  "10.6 Overzicht responscodes MasterCard, VISA, Maestro, V PAY en Bancontact/Mister Cash":
  90 Rabo OmniKassa-server tijdelijk niet bereikbaar
• Page 32, "10.7 Overzicht responscodes iDEAL":
  Failure sending in, De bank van de betaler niet bereikbaar. 90 Nee
• Page 33, "10.8 Overzicht responscodes MiniTix":
  90 Systeemfout 90 Nee

Which seems to be an error response in all cases it is defined (in the manual).

Did something change, did I miss something in the manual that says it should be treated as a pending response?

I just tried to install this gem in a Rails 4.1.1 project using bundler under Ruby 2.1.2 on OSX 10.9:
gem "omni_kassa", "~> 1.4" => bundle install

and got the following error:

Gem::Package::PathError: installing into parent path /Users/pepijn/Code/omni_kassa/Gemfile of /Users/tom/.gem/ruby/2.1.2/gems/omni_kassa-1.4.2 is not allowed
An error occurred while installing omni_kassa (1.4.2), and Bundler cannot continue.
Make sure that `gem install omni_kassa -v '1.4.2'` succeeds before bundling.

/Users/pepijn/Code/omni_kassa/Gemfile seems to be a hardcoded path, but it is specified no where in the gem code.
I've tried installing it with ruby-1.9.3-p545 and ruby-2.0.0-p451 as well, no luck.

It a bit of an odd problem. That would mean almost no one would be able to install it. Colleagues of mine can't install it either so, it seems to be the case? I've tried it using bundler and just with gem install omni_kassa, but neither method works.

Only thing I can imagine is that when releasing the gem it somehow pushed the full local paths of @pepijn rather than relative paths.

I cloned the repo and pointed to the local version: gem "omni_kassa", path: "/Users/tom/projects/omni_kassa", then it works fine, but that's no real solution.

When I do omnikassa.perform I get the following error (both locally as in my production environment)

SSL_connect returned=1 errno=0 state=unknown state: wrong version number

I think this is due to https://github.com/pepijn/omni_kassa/blob/master/lib/omni_kassa/request.rb#L35 where you specify ssl_version: :SSLv3 but I don't think the Rabobank server supports this (anymore).

It does work when I use the direct HTTP request, without specifying the ssl_version, like this:

render text: HTTParty.post(OmniKassa.url, query: omnikassa.query).body

Based on the comment you've only included this for TravisCI, so I'm a bit hesitant to create a pull for this, but if you have an idea how to fix this I'm glad to help.