penberg / falcon Goto Github PK

Hi!

I'm struggling with groups in messages at the moment. I guess it would be useful to write a Group class to make adding a group to a message more easy?

Ciao,
Andreas

Have you benchmarked this against other implementation like http://fix8.org/

Hi!

Thanks for your great work!

Maybe you could add 2 message types?

public static final MessageType OrderCancelRequest = new MessageType("F");
public static final MessageType MarketDataRequest = new MessageType("V");

I created a subclass of the MessageTypes just to add these 2. So I could remove this class.

Hi,
In the recv() method(Session.java), parse a step message and get it's fields. The code is below:
while (rxBuf.position() < checksumOffset) {
int tag = Protocol.parseInt(rxBuf, (byte)'=');
ByteString value = Protocol.parseString(rxBuf, (byte)0x01);
fields.add(new Field(tag, value));
}
Maybe there is a bug in while loop:
parseString(ByteBuffer buf, byte delimiter) {
int start = buf.position();
for (;;) {
byte ch = buf.get();
if (ch == delimiter) {
break;
}
}
//buffer's posion is one after delimiter
//the end is pointer to delimiter
int end = buf.position() - 1;
buf.position(start);
return ByteString.of(buf, end-start);
}
after return ,the buffer's postion is pointer to delimiter. If next call parseInt(), the tag is error.
I think it should add rxBuf.get() before fields.add().
And I submit a SessionTest for this. Please check it. Thanks.

I checked the code and see that recv() just return a empty Message. Is the method supposed to run or it's just a temp place holder?

Also the Session class are littered with System.out.println?

Hi!

There are no Field subclasses for Field for specific fieldsm like NoRelatedSym, MDReqID etc?
Is this intentionally, so you have to use new Field( , ) ?
Make the sources no very usable, I think? I wrote me a simple code generator in Python to create subclasses from a simple text file.
Maybe this costs some performance, but creates nicer sources?

Ciao,
Andreas