Coder Social home page Coder Social logo

Comments (4)

dianashk avatar dianashk commented on June 30, 2024

This should be taken into consideration during API redesign.

Related to pelias/pelias#42

from api.

missinglink avatar missinglink commented on June 30, 2024

There has been a fair bit of discussion around the consumer having more control over the properties returned by API, most notably #101

There is certainly a tradeoff in trimming the db response in javascript as mentioned in #122 (comment)

If we decide to offer this level of configuration we should do it at query-time rather than in the controller code by adding a fields params to all queries. This will give us a speed-up all the way down the stack and all the way back up again, plus the problems of selectively mapping the data to the JSON response go away.

In order to accomplish this, we would need to rejig our queries a bit as the response body from elasticsearch for a fields query is different from a normal search query (._source becomes .fields)

It's also important for the API redesign discussion that we discuss what the "default params" will be, as a new user of the API you should be able to get a decent set of params that cover most usecases, this functionality would just be for super-users who want to squeeze every last bit of performance out of the service, mostly those targeting mobile phones.

from api.

dianashk avatar dianashk commented on June 30, 2024

Hold off until API-redesign

from api.

dianashk avatar dianashk commented on June 30, 2024

No longer relevant. Covered by the introduction of the view parameter.

from api.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.