Coder Social home page Coder Social logo

fix: test case fails for diffPlaces about api HOT 3 CLOSED

wasi-m avatar wasi-m commented on August 17, 2024
fix: test case fails for diffPlaces

from api.

Comments (3)

orangejulius avatar orangejulius commented on August 17, 2024 1

I just merged #1655 to pin to a version of remove-accents that operates how our unit tests expect and we believe to be correct. Sounds like we can undo that pin in the near future though, as remove-accents may revert the change that broke our tests. Until then tests are passing again for everyone :)

from api.

michaelkirk avatar michaelkirk commented on August 17, 2024

This test is failing for me too.

It seems like the underlying remove-accents package is implicated.

The test is depending on behavior from this change: tyxla/remove-accents#12 included first in release v0.4.2.

But that behavior was reverted in 0.4.4 released in November '22.
See tyxla/remove-accents#31

I don't really know what behavior is better. But if we want to just delegate that decision to remove-accents, then as well as updating this test, it might make sense to bump the minimum version of remove-accents to 0.4.4 to keep everything coherent.

from api.

missinglink avatar missinglink commented on August 17, 2024

Hi, thanks for tracking this down, I alerted the author in the linked issue above.

from api.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.