pelian / codeacademy Goto Github PK

I love how much effort you put in it, not trying to underestimate anyone, mainly because it is noticeable that you have an ease for programming and that the task at hand was not as challenging for you, thus instead of just quickly finishing the project, you decided to take time and improve it by implementing ui details, and a better user interaction approach.

What a wonderful take on the ol' Jammming project. It is refreshing, completely integrated, and with a great sense of style.

One unrelated thing. I do understand the reasoning to keep one repository for all your Codecademy projects, but it will be cleaner to have each project in its own repository, that way for example, I will not have to clone all your prior projects just to test your Jammming app. The same will apply when you work at any company where the application will have its repository, and you and the team will work in it in different branches.

Rubric Score

Criteria 1: Matplotlib and CSV

• Score Level: 4/4 (Exceeds Expectations)
• Comments: You imported the necessary libraries.

Criteria 2: Implementation of 2D Visualization

• Score Level: 4/4 (Exceeds Expectations)
• Comments: Not only did you create a 2D plot of the constellation, but you also added an appropriate title and gave each star a unique color. Well done!

Criteria 3: Implementation of 3D Visualization

• Score Level: 4/4 (Exceeds Expectations)
• Comments: You created a rotatable 3D plot of the constellation with an appropriate title and a unique color for each star. Good job!

Overall Score: 12/12 (Exceeds Expectations)

Great work! You created all of the necessary plots, and used some more advanced syntax in order to make the random colors work. My one recommendation would be to consider using the same color scheme (as in the same static pairings of unique colors for each different star) for both of these plots instead of random colors, though, as this would allow you to easily match the stars from the 2D plot to their counterparts in the 3D plot by color, thereby potentially making the colors more useful. Again, great job!

Overall, your work met the project specifications!! Great work! :)

Your code is very neat and I don't see any issues there.
I think your presentation is very very sleek and professional. Your visualizations are complimented by insightful bodies of texts, a good balance. I will say that one or two of your graphs are a bit too small and could've been bigger. Other than that, awesome stuff! Keep it up.

Great job implementing a ui library, it sure set your application apart from any other project I have seen, implementing simple grid components and a loader gives the application more body.

Throughout your program, you have boolean expressions that are correct, but redundant. Here's one:

if self.name == other_user.name and self.email == other_user.email:
   return True
return False

This if-statement is not necessary at all. Look at what you're doing. You're checking to see if that boolean expression is True or False. If True, return True. If False, return False. Checking the value is unnecessary work. Just return the expression.

return self.name == other_user.name and self.email == other_user.email

Grade: Surpasses requirements and expectations
A total 200 ok! Congratulations for an amazing work on the Jammming project!

I hope you get to play with react-router-dom soon, and I believe you would appreciate to work with redux, here's one of their tutorials to get acquainted with it: https://redux.js.org/basics

You are more than ready to tackle the feature request, so best of luck on you future ventures!

Rubric Score

Criteria 1: Valid Python Code

• Score Level: 4

Criteria 2: Implementation of Project Requirements

• Score Level: 4

Criteria 3: Software Architecture

• Score Level: 4

Criteria 4: Uses Python Language Features

• Score Level: 4

Overall Score: 16/16

Your work definitely meets the project requirements -- awesome work!! My issues were just style/formatting. The actual logic of your program is really great and demonstrates that you have a very strong understanding of the course material. Congrats on finishing the course and best of luck in your future endeavors!

starting this year it has become a better practice to implement arrow functions for the methods, for example your addTrack method would look like so:

 addTrack = (track) => {
    if (!this.state.playlistTracks.find(playlistTrack => playlistTrack.id === track.id)) {
      this.setState({
        playlistTracks: [...this.state.playlistTracks, track]
      });
    }
  }

Now, that simple adjustment will allow you to use the properties of arrow functions related to the keyword this. which means it will be always be related to the lexical context where it was created (in this case your Jammming class), and thus it will not need to have the extra effort of binding the method in the constructor, because no matter where the method is being called, the value of this will always relate to the class where the method was created.

Your use of .format() is very readable but in my opinion, unnecessary work.
Let's look at this line:
'TomeRater has {users} users and {books} books'.format(users=len(self.users), books=len(self.books))
You don't have to give the variables in the string names, nor do you have to define them inside of the function. Just do this:
'TomeRater has {} users and {} books'.format(len(self.users), len(self.books))
You should only give the variables inside the string values if you are not going to use the variables inside of .format() in the order you passed them in.

Implementing the album cover is a simple change into the response that upscales the experience. Well worth doing. Nice decision to return a new resolve promise rather than just a response code

Great use of async/await to stream through the fetch responses.

Using sessionStorage not just to keep the access token but also to manipulate it with your log in is an amazing over-implementation for the app which does provide a very comfortable feeling on the use of the service.

You have already covered the option of having a search triggered by clicking the enter key