pdud / ember-cli-build-notifications Goto Github PK

Thank you for the wonderful addon! Let me describe my use case. I believe, it's typical for most Ember coders.

When I edit the code and save, I want to know when my app livereloads and finishes loading routes, so that I can open the tab and inspect the result.

The time the app takes to reload is not enough to do something productive (switching contexts is expensive), but enough to be bored to death, especially when you code in short cycles. So I often switch to Twitter or funny cat pics while the app is building and reloading. It also helps depressurize the brain.

The problem here is that I keep relaxing after the app finishes loading and it takes me a while to realize I'm distracted. I need a notification that would tell me that I can get back to work. The buildSuccess notification doesn't help, because after a successful build a large app still takes a lot of time to reload.

I'm sure I'm not the only Ember developer having this problem.

I'm not sure how this can be approached, and it's probably out of scope of the addon. But as this addon provides access to notifications, I post this feature request here.

Probably we need to run a dev server, similar to livereload or code coverage reporting. The server has to be poked when all routes have finished their afterModel hooks, or something like that. Let's discuss possible implementations.

Hey.

Is there any particular reason we're forcing a peer dependency of at least ember-source 3.28?
Why do we need this at all for this add-on?

https://github.com/pdud/ember-cli-build-notifications/blob/main/package.json#L76

Howdy! I know, at least for growl and osx, that a user can configure whether the notifications should be kept in the history. I'm wondering if there is a way for the tool to say that it should not keep this in the history preemptively. I'm proposing this addon be part of the default ember install but the notification center noise is kind of a blocker.

I did some digging around node-notifier to find an answer but I'm not sure if the apis expose this ability. Have you looked into this?

DEPRECATION: ember-cli-babel 5.x has been deprecated. Please upgrade to at least ember-cli-babel 6.6. Version 5.2.8 located: ember-cli-build-notifications -> ember-cli-babel

Does this also work w/ the testing setup in ember-cli? ie- will it show you a failure for unit or acceptance tests?

If so -what do I need to add to get this working w/ the test setup?

I get the following when doing ember s

TypeError: Cannot read property 'addListener' of undefined
    at Object.exports.execFile (child_process.js:788:15)
    at Object.exports.exec (child_process.js:649:18)
    at Object.module.exports.command (/Users/moogs/Dropbox/Development/app/node_modules/ember-cli-buil
d-notifications/node_modules/node-notifier/lib/utils.js:45:13)
    at NotificationCenter.notify (/Users/moogs/Dropbox/Development/app/node_modules/ember-cli-build-no
tifications/node_modules/node-notifier/notifiers/notificationcenter.js:62:11)
    at Class.module.exports.buildError (/Users/moogs/Dropbox/Development/app/node_modules/ember-cli-bu
ild-notifications/index.js:11:14)
    at /Users/moogs/Dropbox/Development/app/node_modules/ember-cli/lib/models/builder.js:122:34
    at Array.map (native)
    at Class.module.exports.Task.extend.processAddonBuildSteps (/Users/moogs/Dropbox/Development/app/n
ode_modules/ember-cli/lib/models/builder.js:120:43)
    at Class.<anonymous> (/Users/moogs/Dropbox/Development/app/node_modules/ember-cli/lib/models/build
er.js:149:14)
    at lib$rsvp$$internal$$tryCatch (/Users/moogs/Dropbox/Development/app/node_modules/ember-cli/node_
modules/rsvp/dist/rsvp.js:489:16)
    at lib$rsvp$$internal$$invokeCallback (/Users/moogs/Dropbox/Development/app/node_modules/ember-cli
/node_modules/rsvp/dist/rsvp.js:501:17)
    at lib$rsvp$$internal$$publish (/Users/moogs/Dropbox/Development/app/node_modules/ember-cli/node_m
odules/rsvp/dist/rsvp.js:472:11)
    at lib$rsvp$$internal$$publishRejection (/Users/moogs/Dropbox/Development/app/node_modules/ember-c
li/node_modules/rsvp/dist/rsvp.js:415:7)
    at lib$rsvp$asap$$flush (/Users/moogs/Dropbox/Development/app/node_modules/ember-cli/node_modules/
rsvp/dist/rsvp.js:1290:9)
    at process._tickCallback (node.js:355:11)
events.js:85
      throw er; // Unhandled 'error' event
            ^
Error: spawn /bin/sh EMFILE
    at exports._errnoException (util.js:746:11)
    at Process.ChildProcess._handle.onexit (child_process.js:1053:32)
    at child_process.js:1144:20
    at process._tickCallback (node.js:355:11)

Here is some information:

http://developer.ubuntu.com/en/apps/platform/guides/push-notifications-server-guide/

Awesome men! thanks!

Hi! Great tool! Love it!

I just upgraded an app to ember 2.10.1 and I am now getting some funny business in my notifications.

It looks like:

I suspect this is because the build are so fast now from 2.10.1 that it cannot even be measured.

Let me know if there is anything I can do to help!